Giter Site home page Giter Site logo

Comments (4)

patrickkaleta avatar patrickkaleta commented on June 20, 2024 1

I would suggest to disable this feature and close this issue. Changing the study type shall no longer be allowed. For the implementation and testing phase it was helpful, but in the operational system it will just confuse users, e.g. if some steps or even results disappear after (accidentally?) changing the study type as observed here. Moreover, as steps are recreated, it breaks all permalinks containing a step id.

I agree. Setting the Study type should only be possible once during the initial creation of a new Study, since it has such a big (and unpredictable) impact on everything else. I'll remove the Study type field from all edit forms, so that it cannot be changed once it's set.

from csis-helpers-module.

patrickkaleta avatar patrickkaleta commented on June 20, 2024

Emikat is now triggered only when the selected study type contains calculation methods that are appropriate for Emikat. Such calculation methods are those that have the emikat keyword in the Calculation method ID field.

ToDo:

Since the study type can be changed by the user, we have to take into account the possiblity, that a previously irrelevant study suddenly becomes relevant for Emikat and vice versa.

case 1)
non-relevant -> relevant: that's the simple case, since this will basically be like an "intial Emikat trigger" event, where the Study is sent to Emikat for the very first time. No action needed here

case 2)
relevant -> non-relevant: In this case the study might already be stored on Emikat-side, so we need to tell Emikat that (for the moment) this study is not active. Need to discuss with @humerh how this could be implemented.

from csis-helpers-module.

DenoBeno avatar DenoBeno commented on June 20, 2024

from csis-helpers-module.

p-a-s-c-a-l avatar p-a-s-c-a-l commented on June 20, 2024

Since the study type can be changed by the user, we have to take into account the possiblity, that a previously irrelevant study suddenly becomes relevant for Emikat and vice versa.

I would suggest to disable this feature and close this issue. Changing the study type shall no longer be allowed. For the implementation and testing phase it was helpful, but in the operational system it will just confuse users, e.g. if some steps or even results disappear after (accidentally?) changing the study type as observed here. Moreover, as steps are recreated, it breaks all permalinks containing a step id.

from csis-helpers-module.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.