Giter Site home page Giter Site logo

Comments (3)

clarkbw avatar clarkbw commented on May 23, 2024

Looks like we check that we call the callback

expect(callback).toHaveBeenCalledTimes(1);

And yes, looks like you're right that we don't pass it along

sendMessage: jest.fn((message, cb) => {

Can you check that this is the correct behaviour and open a PR fixing the library? thx!

from jest-webextension-mock.

kmarple1 avatar kmarple1 commented on May 23, 2024

After some reading on MDN, it seems like the callback itself is deprecated, so there's probably no point in adding it now. The expected behavior would be for everything to be Promise-based, but that would likely be a major revision.

from jest-webextension-mock.

clarkbw avatar clarkbw commented on May 23, 2024

We handle promises but we probably don't do it correctly

return Promise.resolve();

from jest-webextension-mock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.