Comments (3)
Looks like we check that we call the callback
jest-webextension-mock/__tests__/tabs.test.js
Line 120 in f66b8b8
And yes, looks like you're right that we don't pass it along
jest-webextension-mock/src/runtime.js
Line 18 in f66b8b8
Can you check that this is the correct behaviour and open a PR fixing the library? thx!
from jest-webextension-mock.
After some reading on MDN, it seems like the callback itself is deprecated, so there's probably no point in adding it now. The expected behavior would be for everything to be Promise-based, but that would likely be a major revision.
from jest-webextension-mock.
We handle promises but we probably don't do it correctly
jest-webextension-mock/src/runtime.js
Line 23 in f66b8b8
from jest-webextension-mock.
Related Issues (20)
- Make runtime.onMessage react to tabs.sendMessage HOT 3
- Add support for browser/chrome.management.* APIs
- Add contribution guidelines HOT 1
- chrome.storage.local.get should return a deep copy of objects
- onMessageExternal missing from from runtime mock HOT 1
- `browser.permissions` is missing HOT 3
- Question: Is webextension-polyfill 0.9.0 supported? HOT 3
- `This script should only be loaded in a browser extension` HOT 1
- Support for manifest version 3 HOT 1
- Missing onChanged on chrome.storage.sync HOT 1
- Add support for runtime.getManifest HOT 1
- BUG: "Cannot read property 'addListener' of undefined" for `browser.storage.local.onChanged.addListener` HOT 3
- Vitest support HOT 5
- Struggling with ts-jest HOT 2
- chrome.runtime.onMessage inconsistent callback parameters? HOT 1
- throw new Error('Wrong key given'); HOT 1
- Add support for browser.webRequest API HOT 1
- Add `sidePanel` API HOT 1
- Separate storage values by type HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jest-webextension-mock.