Lowfat is falling behind (missing attributes)

[jonathanrobie]

Lowfat is falling behind (missing attributes)

[ryderwishart]

This will be easy to fix. I'll take care of it. 👍

[ryderwishart]

It turns out we lost some nodes on the last transformation @klosoter @jonathanrobie. For example, we lost xml:id="o010380240022". Any chance we can revert the last merge before adding glosses/annotations and try again?

The problematic commit is

5e3d166 Added glosses/annotations | changed Node/@xml:id to Node/@n

and the commit that merges it is

b35d3d8 Merge pull request #49 from Clear-Bible/latest-glosses-and-annotations

See diff screenshot here:

[klosoter]

On it

[klosoter]

I see what happened. Nodes 010380240022-3 (and a few others like this) got removed when I copied them to a new XML file that documents issues. I've used deepcopy now, so this should be resolved.

[klosoter]

There were multiple issues with lowfat and the full trees, when I tried to add the glosses and other data there as well. Most of them are very similar to the problems I had with NT-lowfat.

In full trees:

• Changed Node/@xml:id to Node/n because it was a duplicate of Node/m/@xml:id (not allowed for ids)

In lowfat:

• prepended "o" to wg/@xml:id where absent (NCName can't start with a digit)
• there were 136 cases where Node/m was not changed into wg/w, each time with the same morph: אוּלַ֥י
  • changed Node/m to wg/w
  • applied previous operation on it to retain Node/@nodeId as Node/@xml:id (with extra "o")
  • removed Node/@nodeId

@ryderwishart, I'm interested, though, why and when did this morpheme get skipped?

[klosoter]

Then I added the glosses and annotations to lowfat and full trees