Compilation error on latest release

[cleishm]

Compilation error on latest release

[mannol]

Resolved by installing peg utility.

[cleishm]

Hi @mannol,

Was this with the downloaded distribution tarball, or with a download of the github repo?

Cheers,
Chris

[mannol]

It was with the downloaded distribution tarball.

[cleishm]

Thanks. Interestingly, the distribution tarball already contains cli_parser_leg.c, and it shouldn't have needed to be rebuilt - indeed without leg on the system, autoconf/make shouldn't be adding Makefile rules to rebuild it at all. So I'm quite confused how you got that error!

[mannol]

This looks like it's a general issue with a makefile. I'm running Ubuntu 16.04 LTS and neo4j-client is not installed by running make install either. Manually copying it in /usr/bin/ works.

[cleishm]

That's very odd. I've just tried the same on Ubuntu 16.04 LTS (in docker) and not had that issue.

$ docker pull ubuntu:latest
...
$ docker run --rm -ti ubuntu /bin/bash
root@27bce08e968a:/# apt-get update
...
root@27bce08e968a:/# apt-get install -y build-essential check file libedit-dev libssl-dev pkg-config wget
...
root@27bce08e968a:/# wget https://github.com/cleishm/libneo4j-client/releases/download/v0.9.1/libneo4j-client-0.9.1.tar.gz
...
root@27bce08e968a:/# shasum -a 256 libneo4j-client-0.9.1.tar.gz
37e85a33735e475870a4799a0994690be0ff92681e1b60bfbfc7fc08964bbc7d  libneo4j-client-0.9.1.tar.gz
root@27bce08e968a:/# wget https://github.com/cleishm/libneo4j-client/releases/download/v0.9.1/libneo4j-client-0.9.1.tar.gz.asc
...
root@27bce08e968a:/# gpg --recv-key 565E89E0
...
root@27bce08e968a:/# gpg --verify libneo4j-client-0.9.1.tar.gz.asc libneo4j-client-0.9.1.tar.gz
gpg: Signature made Mon Apr 25 10:22:13 2016 UTC using RSA key ID 565E89E0
gpg: Good signature from "Chris Leishman <[email protected]>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 80F6 D6B0 D90C 6747 7533  44CA B5A9 E81B 565E 89E0
root@27bce08e968a:/# tar xzf libneo4j-client-0.9.1.tar.gz
root@27bce08e968a:/# cd libneo4j-client-0.9.1
root@27bce08e968a:/libneo4j-client-0.9.1# ./configure
...
root@27bce08e968a:/libneo4j-client-0.9.1# make
...
root@27bce08e968a:/libneo4j-client-0.9.1# make check
...
root@27bce08e968a:/libneo4j-client-0.9.1# make install
...
root@27bce08e968a:/libneo4j-client-0.9.1# file /usr/local/bin/neo4j-client
/usr/local/bin/neo4j-client: ELF 64-bit LSB  executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.24, BuildID[sha1]=0a88cdea9d40261ee4abdd5458f68c6b084254ef, not stripped

BTW - you may prefer to install using the ubuntu packages? See https://launchpad.net/~cleishm/+archive/ubuntu/libneo4j-client

[mannol]

I tried using PPA first; it installed the client, but clang and I couldn't find the header file. It may be my computer is haunted.

[cleishm]

To get the header file, you need to install the libneo4j-client-dev package. I've updated the README to suggest that (15cc84f).

[Dan-McG]

same No rule to make target 'cli_parser_leg.c' error on Archlinux after make clean check from a git clone... resolved after installing peg, not tried leg - thanks for hint @mannol

[cleishm]

Hi @Dan-McG,

From a git clone, you must have the peg/leg tool installed and available. I've mentioned that in the README (here: https://github.com/cleishm/libneo4j-client#building), but I guess it's not clear enough. I might try to improve the configure script, or the makefile, so that it fails a little more dramatically in this situation.

Cheers,
Chris

[Dan-McG]

ahh no, no, it's very clear now! i just got blinded by the list of standard tools that i knew i had