Giter Site home page Giter Site logo

list_remove should check node to NULL about list HOT 3 OPEN

clibs avatar clibs commented on July 29, 2024
list_remove should check node to NULL

from list.

Comments (3)

stephenmathieson avatar stephenmathieson commented on July 29, 2024

Currently we expect you to check the return value of list_find:

list_node_t *thing = list_find(list, "value");
if (thing != NULL) {
  list_remove(list, thing);
}

I think this is a reasonable thing to do. What is the use case for not checking the return value yourself?

from list.

LuisCRSousa avatar LuisCRSousa commented on July 29, 2024

A lib should be bullet proof and check for this kind of edge cases that's all.
I just wanted to do it in one line of code, there's no need to repeat the same code over and over again.

Thanks :)

from list.

stephenmathieson avatar stephenmathieson commented on July 29, 2024

Feel free to open a PR :)

from list.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.