Giter Site home page Giter Site logo

Comments (5)

olofhagsand avatar olofhagsand commented on July 25, 2024

Thanks for putting attention on this.
But no, [email protected] in the clixon repo is an effort to recreate RFC5277 create-subscription and the types around that. RFC5277 does not contain a Yang model, just XML schema, so the yang model was manually created from the RFC.
[email protected] on the other hand, (eg https://github.com/YangModels/yang/blob/master/standard/ietf/RFC/[email protected]) is RFC 6470, so is a completely different yang model. The confusion is that they are names (almost) the same.
I see Cisco has the original RFC5277 at, for example https://github.com/YangModels/yang/blob/master/vendor/cisco/xr/651/notifications.yang.
There is a relatively recent model at draft-ietf-netconf-rfc5277bis-01 which is modeled by Cisco in for example https://github.com/YangModels/yang/blob/master/vendor/cisco/xe/1681/ietf-event-notifications.yang where create-subscription is still defined. There are also new rpc:s for subscribed-notifications.
So there are a number of different options:

  1. keep the original (maybe rename it for avoiding similar confusion)
  2. Use cisco's "notification.yang" (I would want to have a proper source though)
  3. Upgrade to draft-ietf-netconf-rfc5277bis-01. I have no idea how much work that is.
  4. Follow the more recent work,eg at https://github.com/netconf-wg/rfc5277bis for subscribed-notifications. But there I think create-subscription is obsolete.
  5. someting else?

from clixon.

dcornejo avatar dcornejo commented on July 25, 2024

name confusion noted.

the simplest change is to fix two instances of date-and-time types that are missing the yang: prefix and should be yang:date-and-time (see patch below)

yangval-patch.txt

from clixon.

olofhagsand avatar olofhagsand commented on July 25, 2024

This opened up some other issues:

  1. clixon hardcoded some yang types such as date-and-time, ipv4-address, etc. thus bypassing the yang date-and-time regexp. This has now been removed.
  2. cligen didnt properly support time-zone designators (eg 'Z' or +01:00). CLIgen now supports it.
  3. cligen uses posix regex while yang uses XSD. It differs in some aspects. A translator function has been added.

from clixon.

olofhagsand avatar olofhagsand commented on July 25, 2024

Note that the yang module has been renamed: ietf-netconf-notifications -> clixon-rfc5277.

from clixon.

dcornejo avatar dcornejo commented on July 25, 2024

thank you!

from clixon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.