Comments (3)
Ahhh I see.
I should store a null in the output.
Right now the function doesn't return a char*. I can't change that without
breaking ABI compatibility (I think).
Let me make a test case and fix will be forthcoming.
thank you!
Original comment by [email protected]
on 24 Feb 2012 at 5:22
from stringencoders.
Original comment by [email protected]
on 24 Feb 2012 at 5:24
- Changed state: Started
from stringencoders.
Actually, I misread my own code. The function does not return a pointer, it's
void, so if you are using the return value, it's likely to be bogus.
The corner cases do 'return' but also set the buffer to 'nan' or 'inf' as appropriate.
In general i think these function SHOULD return a pointer, but i can't change
it now without breaking binary compatibility.
Thanks for your time here. If you think I got this wrong, please reopen.
Original comment by [email protected]
on 26 Feb 2012 at 4:21
- Changed state: Invalid
from stringencoders.
Related Issues (20)
- base32 HOT 4
- compilation errors on intel mac regarding modp_b64.c HOT 3
- Patch for /trunk/javascript/base64.js
- Corruption of const input string that use C.O.W. HOT 1
- Library fails to build on sparc,powerpc,arm because of bad casting in the test suite HOT 1
- Duplicate base64 encoding tables? HOT 2
- Patch for /trunk/javascript/base64.js
- invalid type used in function: void modp_litoa10(int64_t value, char* str) HOT 1
- Patch for /trunk/javascript/base64-speed.html
- Em Dash character causes an exception in base64.js HOT 1
- dtoa & dtoa2 lose a fractional leading '0' HOT 2
- dtoa & dtoa2 should be short-circuited for values of 0.0 HOT 2
- modp_dtoa() fails for input of 0.95 with precision of 1 HOT 8
- not an issue just: new proposal for modp_stdint.h again HOT 1
- Please document required alignment for modp_b64_decode()
- Variant which protects against buffer overflows HOT 2
- Few suggested improvements
- modp_b64_gen.c generates two identical char arrays HOT 2
- Round-to-even bug in modp_dtoa2
- modp_b64_test.c failed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stringencoders.