does this support windows?

[cliffrowley]

does this support windows?

[cliffrowley]

I would like it to support Windows, but I'm a Mac user myself. To be fair I created this package when Atom was Mac only - I will update the README for now and then perhaps add Windows support later. I'm also happy to accept a pull request :-)

[mark-hahn]

Maybe I'll do a PR. I'd really like to have this.

On Tue, Jan 27, 2015 at 3:40 AM, Cliff Rowley [email protected]
wrote:

I would like it to support Windows, but I'm a Mac user myself. To be fair
I created this package when Atom was Mac only - I will update the README
for now and then perhaps add Windows support later. I'm also happy to
accept a pull request :-)

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

[cliffrowley]

@mark-hahn that would be awesome. I'm also happy to give you collaborator access as it makes sense to have someone on both platforms (e.g. I wouldn't notice if something got inexplicably broken on Windows).

[mark-hahn]

No need. I will let you know if it breaks. It should always work on
windows when it works on mac if I put in the right windows command.

On Tue, Jan 27, 2015 at 3:24 PM, Cliff Rowley [email protected]
wrote:

@mark-hahn https://github.com/mark-hahn that would be awesome. I'm also
happy to give you collaborator access as it makes sense to have someone on
both platforms (e.g. I wouldn't notice if something got inexplicably broken
on Windows).

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

[cliffrowley]

Sure. I'm pretty busy so if you find I'm not responsive feel free to change your mind ;-)=

[mark-hahn]

You were responsive this time. :-)

On Tue, Jan 27, 2015 at 3:37 PM, Cliff Rowley [email protected]
wrote:

Sure. I'm pretty busy so if you find I'm not responsive feel free to
change your mind ;-)=

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

[cliffrowley]

You got lucky! :-P

[cliffrowley]

@mark-hahn I've integrated your pull request and I've pushed the amendments to the master branch. I haven't released it yet because there are a couple of changes I need to make first (doing so now). Won't be long and I'll publish.

[cliffrowley]

Changes done, but I haven't had a chance to test it on Windows yet. If you get a chance to do it before me, please let me know and I'll close this issue :-)

[mark-hahn]

I'm sorry, but I have managed to rid myself of all windows (yahoo).

On Fri, Jun 5, 2015 at 6:26 PM, Cliff Rowley [email protected]
wrote:

Changes done, but I haven't had a chance to test it on Windows yet. If you
get a chance to do it before me, please let me know and I'll close this
issue :-)

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

[cliffrowley]

Hah good on you ;-)

[cliffrowley]

Enhancement added as issue #13