Arithmetic rules not capturing correctly

[clj-commons]

Arithmetic rules not capturing correctly

[jonase]

check-form only checks the 'outer' expression which is why it doesn't see (= 0 0). This is by design.

We could add a check-expr function which would walk through all the subexpressions, something like:

(defn check-expr [expr]
  (keep check-form (expr-seq expr)))

Note the similarity between check-expr and check-file.

[ohpauleez]

That makes WAY more sense now that I look at the code. I'll play around in a branch and see if I can come up with anything

[ohpauleez]

So what about creating a map of {expr checked-expr, ...} pairs, then using the map to build the final form back up? We could even use filter to make sure we only get valid forms. Check out the REPL session:

user=> (def s (kibit/expr-seq '(if (= 0 0) (println "a") (println "a"))))
#'user/s
user=> user=> (def fs (filter #(.startsWith (str %) "(") s))
#'user/fs
user=> (zipmap fs (map kibit/check-form fs))
{(println "a") nil, (= 0 0) {:expr (zero? 0), :rule [(zero? 0) true], :alt true, :line nil}, (if (= 0 0) (println "a") (println "a")) nil}
user=> (zipmap fs (map #(-> % kibit/check-form :alt) fs))
{(println "a") nil, (= 0 0) true, (if (= 0 0) (println "a") (println "a")) nil}
user=> (filter val rm)
([(= 0 0) true])

Or maybe use walk ?

user=> expr
(if (= 0 0) (println "a") (println "a"))
user=> (clojure.walk/walk #(or (-> % kibit/check-form :alt) %) kibit/check-form expr)
{:expr (if true (println "a") (println "a")), :rule [(if true ?x . ?y) ?x], :alt (println "a"), :line nil}

[ohpauleez]

Walk was the winner, totally awesome

The branch is here

This got pushed onto kibit/master