Comments (4)
Here's a very related occurence.
[91] Consider:
(.add (.getContentPane) (JScrollPane. label))
instead of:
(-> (.getContentPane) (.add (JScrollPane. label)))
While this looks correct when viewed isolated, it's wrong if you check the complete context:
(doto frame
(-> (.getContentPane)
(.add (JScrollPane. label)))
(.setDefaultCloseOperation WindowConstants/DISPOSE_ON_CLOSE)
(.addKeyListener ...))
As you can see, frame
will be injected as first form into the threading form by the doto
. With the suggestion, frame
would be injected into the (.add #_frame-would-end-up-here (.getContentPane) (JScrollPane. label))
form and render it invalid.
from kibit.
In general, I think this is a fundamental limitation of kibit. Since kibit reads the source without macroexpanding it first it's easy for a macro to invalidate a rule.
from kibit.
Yes, after thinking about it, I came to the same conclusion. Anything that's nested inside some macro can be transformed to possibly anything.
Would it be possible to restrict kibit to forms that aren't inside a macro or only inside some whitelisted macro we know it won't restructure the code in inexpected ways (like defn, fn, do, when, ...)?
from kibit.
@tsdh because we don't evaluate any of the code in Kibit, I don't think we can know which forms are inside a macro or just another users function. I'm closing this for now as I don't think there's any way to get around this, but I'd be happy to hear if there is.
from kibit.
Related Issues (20)
- deps.edn / clj support HOT 6
- Faulty suggestions for do in vector HOT 2
- Check failures exit with 0
- Need a possibility for Check failures to return exit code 0 with findings HOT 4
- Release the new version with :repository tag
- Faulty rule for not empty HOT 8
- namespace docstrings break kibit... HOT 8
- Kibit evaluates and runs code it parses with no option to disable it HOT 1
- Kibit chokes on ##NaN, ##Inf, etc. HOT 1
- Kibit blows up on qualified keywords when require has a `:refer` HOT 1
- Using `--replace` removes the namespace qualifier `::`
- Kibit cannot parse namespaces with string requires
- -> and ->> in datomic queries
- Incorrect suggestion when using reducers HOT 1
- Getting conditionals read not allowed error in `cljc` file HOT 2
- Wrong suggestion for `(fn [x] [x x])` HOT 1
- Maintenance Status HOT 6
- Should not suggest eta-reduction for macros HOT 2
- Please Release HOT 4
- Arithmetic advices for expm1 and hypot + others
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kibit.