Giter Site home page Giter Site logo

Comments (1)

anna-shcherbak avatar anna-shcherbak commented on September 24, 2024

I do not know if it's a good idea, but what if we reuse the aws.cloudtrail.event-selectors in other places? I haven't found any similar examples in the code, so maybe it's not the best way to do this.
For example in aws.account.check-cloudtrail, the part with the include-management-events check can be rewritten from this:

if self.data.get('include-management-events'):
matched = []
for t in list(trails):
selectors = client.get_event_selectors(TrailName=t['TrailARN'])
if 'EventSelectors' in selectors.keys():
for s in selectors['EventSelectors']:
if s['IncludeManagementEvents'] and s['ReadWriteType'] == 'All':
matched.append(t)
trails = matched

the following way:

        if self.data.get('include-management-events'):
            matched = []
            for t in list(trails):
                data = {
                    'key': "AdvancedEventSelectors[?FieldSelectors[?Field == 'eventCategory' && "
                           "Equals[?contains(@, 'Management')==`true`]] && "
                           "!(FieldSelectors[?Field=='readOnly'])] || "
                           "EventSelectors[?IncludeManagementEvents==`true` && ReadWriteType=='All']",
                    'value_type': 'size',
                    'op': 'gt',
                    'value': 0
                }
                if len(EventSelectors(data, self.manager).process(trails)) > 0:
                    matched.append(t)
            trails = matched

from cloud-custodian.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.