Giter Site home page Giter Site logo

Comments (4)

qiwzhang avatar qiwzhang commented on September 7, 2024

It is good idea, we can use both byte based and time elapse based criteria to trigger a intermediate report.

for example:

if ((read_bytes > T || write_bytes > T) && (time_elapse > 1s))

from esp.

chowchow316 avatar chowchow316 commented on September 7, 2024

The code hook-up is tricky: if we want to remove timer, the intermediate report will be triggered in proxy_flow.cc, which is inside api_manger/grpc, the code structure will become complex. To optimize the performance with timer, we can set a byte threshold (1MB) to trigger the report, and extend the timer period (1s -> 10s).

from esp.

lizan avatar lizan commented on September 7, 2024

No, it won't be tricky, the only tricky part is grpc is currently setting up as a content handler (not a filter)

You should add a IntermediateReport() into RequestHandlerInterface, and call it from grpc_server_call.cc. When we move grpc/transcoding to filter, then IntermediateReport() can be called in filter. All condition check should live in IntermediateReport().

from esp.

chowchow316 avatar chowchow316 commented on September 7, 2024

Added #27 to get rid of timer.

from esp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.