Comments (7)
Me too, but it looks like vectorization doesn't happen when asm is not emitted. I can't really tell, need to look at objdump to see the difference in emitted machine code.
from boringtun.
so i definitely want us to have faster code, but i am a bit sad that this means that we can't enforce clippy on CLI and that contributors will run into a vaguely confusing error when they try to run cargo check
or cargo clippy
. at best i can document this in the README- but i'm still gonna see if i can ask around about conditionally applying --emit asm only to build and not check (not sure it's possible but we'll see!)
from boringtun.
Maybe worth opening an ticket in the rust repo?
from boringtun.
this is a thing that cargo shouldn't fail on, but clippy uses cargo check and check does not like asm
i do not believe there is currently a way to ask cargo check to silently fail and let clippy lint so this blocks our usage of clippy.
from boringtun.
@vkrasnov can you tell me more about the motivation to the .cargo/config --emit asm? i'm a little surprised that it's faster.
from boringtun.
As a work around during a development phase, I suggest to comment the following line to make cargo check
works:
Line 4 in 37be474
from boringtun.
Closed by #223
from boringtun.
Related Issues (20)
- Example to test functionality
- Failed to initialize tunnel HOT 1
- Slow work during testing on VM HOT 17
- The wireguard_write encryption result is different from the official one HOT 5
- libboringtun.so shared lib
- Decapsulate error InvalidCounter (not a huge problem, just curious why it happens and whether I should worry) HOT 2
- Tag 0.6.0?
- Intermittent connection loss with HANDSHAKE(REKEY_TIMEOUT) errors HOT 9
- Add support for mips(el) with ring 0.17.0
- Failed to initialize tunnel, error: Socket kind: NotFound
- any benchmarks against Wireguard? HOT 5
- Apple Silicon Support? HOT 2
- i found it's hard to compile this project to shared lib for android, lets share it here HOT 1
- Bad latest handshake timestamp and keepalives not being sent
- Fails to create API socket when /var/lib/wireguard does not exist
- Appetite for refactoring to be SANS-IO (including time?)
- centos7 host based debian docker image failed to implement boringtun in usersapce
- creation of "connected socket" returns unsupported HOT 1
- Undefined symbol: _new_tunnel HOT 1
- `daemonize` dependency is out of date and has code that will be rejected by a future version of Rust
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from boringtun.