Giter Site home page Giter Site logo

Comments (7)

maximilien avatar maximilien commented on June 18, 2024

@mattcui do you have (or are working on) PR for this?

from bosh-agent.

mattcui avatar mattcui commented on June 18, 2024

@maximilien , haven't, just want to see if they would like to accept this idea before implementation.

from bosh-agent.

cppforlife avatar cppforlife commented on June 18, 2024

Sure. Let's expose this configuration under env.GetRootPassword() (would read root_password off of the env struct;

type BoshEnv struct {
Password string `json:"password"`
}
). If it's not specified in the env use fallback to env.GetPassword().

from bosh-agent.

mattcui avatar mattcui commented on June 18, 2024

@cppforlife In general, we don't change root password, so I think we could make a bit change on your idea, if the root's password is set in env, agent will retrieve and set it as new root password, but if there isn't, agent should not change root's password. How about that? Thanks.

from bosh-agent.

maximilien avatar maximilien commented on June 18, 2024

@mattcui this is open for contribution so this means the BOSH team and @cppforlife wants you or anyone to submit a PR and they will consider it.

from bosh-agent.

mattcui avatar mattcui commented on June 18, 2024

@maximilien @cppforlife , I already submitted PR 32. Please review. Thanks.

from bosh-agent.

cppforlife avatar cppforlife commented on June 18, 2024

closing this issue in favor of discussion in pr#32.

from bosh-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.