WindowsNetManager.setupNetworking contains hard-coded sleep to 5s

[cloudfoundry]

WindowsNetManager.setupNetworking contains hard-coded sleep to 5s

[tylerschultz]

cc @benmoss

[benmoss]

Hey @voelzmo, we have a story in our backlog to get rid of this very line. We introduced it as a bit of a hack because the Windows API we're using appears to be asynchronous without any obvious way to determine when the changes have taken effect. We agree it's not a great solution so we're going to have to find out a better way.

[cunnie]

Thanks @benmoss — Amin & I just ran into this problem, too.

[voelzmo]

@benmoss thanks for the hint. The comment in the story doesn't really sound like you would get to that soon, right? For me this is really an issue when you're touching the net package in the agent. The whole WindowsNetManagerTest takes more than 1 minute now, which makes running the package tests not really suiteable for quick turnarounds...

[benmoss]

It was looked at last week and we tried to figure out a way to poll something in Windows to see when the changes have taken effect, but couldn't. We reprioritized it because of this feedback. The original impetus was more of a code quality thing, but actually slowing down development cycles makes this a higher priority. At worst we can isolate the tests with something like what Kubernetes does here as a short-term solution for you.

[cppforlife]

@benmoss use Clock eg

bosh-agent/app/app.go

Line 171 in 41c0683

timeService := clock.NewClock()

[xoebus]

I've changed it to inject a clock for now as part of fd376ea.

There's still just a basic delay instead of waiting for the actual effect but now the tests take 700ms to pass instead of 60s.