Comments (1)
as it seems that only the values are going trough safe labels and never the keys (which is weird)
see https://github.com/cloudfoundry/bosh-google-cpi-release/blob/master/src/bosh-google-cpi/google/instance_service/google_instance_set_metadata.go#L66
i think we can safly remove that line.
altough i still think we should look in to why its only checking the values and not the keys
as the keys are the one that have restrictions see https://cloud.google.com/resource-manager/docs/tags/tags-creating-and-managing#adding_tag_values
from bosh-google-cpi-release.
Related Issues (20)
- create-env: fails to find and delete VM HOT 1
- Redact logs
- deploy cloudfoundry fail:Error: 'tcp_emitter' is not running after update. HOT 1
- Be able to BOSH deploy something when a GCP zone is out of resources HOT 3
- Instance service delete issue HOT 3
- CPI Quota Error doesn't specify the resource HOT 2
- Support BOSH stemcells upload to a none default region HOT 2
- Flaky communication via CPI HOT 3
- Loss of network when using `migrated_from` HOT 4
- Failed to remove instance from target pool HOT 2
- Minimum CPU platform issue HOT 2
- Add support for Nested Virtualization HOT 3
- Creating vm: Machine Type 'n1-standard-1' does not exists HOT 2
- New bosh google cpi release HOT 3
- Bosh director self snapshots are not being triggered HOT 5
- [read: connection reset by peer] Network issue between bosh CPI and google API HOT 2
- Block project-wide SSH keys for bosh-deployed vms HOT 3
- add the ability to use spot instances in gcp
- Unable to run create-env from darwin HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bosh-google-cpi-release.