Comments (8)
We have created an issue in Pivotal Tracker to manage this:
https://www.pivotaltracker.com/story/show/150113066
The labels on this github issue will be updated when the story is started.
from cf-deployment-concourse-tasks.
It looks like the critical line here is:
export BBL_STATE_DIR=${root_dir}/bbl-state/${BBL_STATE_DIR}
Essentially, our Concourse task would allow users to set their BBL_STATE_DIR to be relative to the bbl-state
input, but we'd expand the relative path to the full path (based on the root_dir of the concourse build).
In that case, what does bbl
expect BBL_STATE_DIR
to look like -- a relative path or an absolute one? In the workflow you described, where a user copies the variables in their pipeline yaml, would bbl
still be able to respect the relative path defined there?
from cf-deployment-concourse-tasks.
@evanfarrar Hey, any updates on this?
from cf-deployment-concourse-tasks.
Hey, sorry I missed this:
The BBL_STATE_DIR
in bbl is fine being relative or absolute, we only expand it in the concourse task to incorporate the "bbl-state" parent directory scheme that cf-deployment-concourse follows. It could be expanded less fully in the task, if you prefer.
from cf-deployment-concourse-tasks.
Hey @evanfarrar. This sounds reasonable. I've updated the story:
Title:
As a Concourse user, I want the bbl-up
task to expand BBL_STATE_DIR
to a full path so that, eventually, bbl can use the value natively.
Acceptance Criteria:
BBL_STATE_DIR
should be converted into a full path early on in the script, a laBBL_STATE_DIR=${root_dir}/bbl-state/BBL_STATE_DIR
- Subsequent uses of
BBL_STATE_DIR
should be not have thebbl-state
namespace as in this line:cf-deployment-concourse-tasks/bbl-up/task
Line 97 in fb6137f
How does that look?
from cf-deployment-concourse-tasks.
I have not answered this in forever but, that looks great.
from cf-deployment-concourse-tasks.
Yo @evanfarrar, do we still need to do this since the release of bbl 5? If so, I'll prioritize it.
from cf-deployment-concourse-tasks.
Hey, I'm going to close this out since I don't think we need to do this after all. Feel free to re-open it if you think this would still be valuable.
from cf-deployment-concourse-tasks.
Related Issues (20)
- `update-integration-configs` should fail fast when `admin_password` is not found HOT 5
- bosh-deploy-with-created-release task should default to `name` if `final_name` is unavailable HOT 5
- bbl 8.4.40 is unable to fetch terraform openstack provider HOT 2
- Require Linux-ARM64 release for cloudfoundry/cf-deployment-concourse-tasks HOT 3
- Why do we install and then remove software-properties-common in cf-deployment-concourse-tasks dockerfile? HOT 2
- Update or remove the `notify-bbl-updates` job HOT 2
- null bug in delete-deployment task HOT 2
- Bump to latest patch of golang in dockerfile HOT 2
- Bump to go1.21
- SYSTEM_DOMAIN sometimes incorrectly derived from "toolsmiths-env" input
- build-docker-image job runs twice every time
- Bump to go1.22
- CF-CLI input in CATS task is not used correctly HOT 2
- Bump to ruby ~3.3
- Discussion: Merge `upload-stemcells` and `deploy` tasks HOT 3
- cf tail command not found in docker image. HOT 5
- Delete Deployment / Destroy Director flag for no fail HOT 3
- release notes incorrect for v7.15 HOT 2
- Pushing creds to credhub rather than git HOT 3
- collect-ops-files task should create $BASE_OPS_FILES_DIR HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cf-deployment-concourse-tasks.