Giter Site home page Giter Site logo

Comments (3)

cf-gitbot avatar cf-gitbot commented on August 16, 2024

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/115607207.

from staticfile-buildpack.

davidjahn avatar davidjahn commented on August 16, 2024

Hi @gberche-orange , thank you very much for your suggestion to turn off nginx logging by default.

Regarding the container's file system max size being exceeded, I do not believe that this is a problem because the two log files are in fact just named pipes created with mkfifo, and do not persist any data to disk.

However, you are correct that many of the nginx log messages are duplicated by the router log messages, and it might be good decision to turn off nginx logging by default. A story in pivotal tracker has been created automatically, and we will discuss the issue further at our next planning meeting. Thanks again!

from staticfile-buildpack.

davidjahn avatar davidjahn commented on August 16, 2024

Hi @gberche-orange , we discussed this issue this morning, and decided that for now we will leave logging turned on by default. There are two reasons for this:

  1. Although the most common log messages (e.g., a successful HTTP request) for nginx are duplicated by gorouter logging, there are possible nginx logging messages (for example, errors) that the gorouter will not duplicate.
  2. It is possible for the user to turn off logging entirely by adding a custom nginx.conf to an app's root folder.

We don't feel that the gain in performance from turning off logging will outweigh the loss of debugging data for the user.

I am closing the issue for now, but please feel free to comment if you have any additional comments to add.

from staticfile-buildpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.