Comments (7)
We have created an issue in Pivotal Tracker to manage this:
https://www.pivotaltracker.com/story/show/128980925
The labels on this github issue will be updated when the story is started.
from staticfile-buildpack.
As I mentioned in the previous ticket, I'm not convinced that environment variables are the appropriate configuration mechanism.
from staticfile-buildpack.
I'd prefer for this to be configurable through the Staticfile
from staticfile-buildpack.
In my opinion the ideal situation for all settings is that you can set a default value in the Staticfile but that you could also override each of those settings with environment variables.
I could see someone wanting HSTS in public-facing production-like environments, but not in lower environments if they don't want the overhead of setting up SSL everywhere.
from staticfile-buildpack.
Depends on whether we consider each thing to be "internal application config" or not as per https://12factor.net/config.
from staticfile-buildpack.
My own opinion is that HSTS should be a switch in the Staticfile
, not an environment variable. These
Environment variables are, ideally, only there to inject app behaviour. This buildpack blurs the line between app and buildpack, but I think we should maintain the distinction nonetheless. We broke this rule for FORCE_HTTPS
, which we ought to deprecate, but in general we've remained consistent.
In particular, Staticfile does not build live applications. By extension from "environment variables are for apps", if there are no apps, there should be no environment variables.
Staticfile's particular brand of snowflakery is that there's no accepted ecosystem tooling and idiom that we're relying on to create and enforce conventions. For example, in Ruby, we don't "think" about these questions much -- we just delegate to Bundler and rubygems and let them set the policy for us.
While having no default idiom or packaging seems like freedom, it's also a scope magnet. I'm personally wary of adding multiple layers of configurability because we will have to entirely own the upkeep.
from staticfile-buildpack.
Closing as this has been implemented in e4efc9b
from staticfile-buildpack.
Related Issues (20)
- [Test Issue]
- problems behind a revers-proxy chain with multivalue x-forwarded-host and x-forwarded-prefix HOT 6
- How to provide application context path while deploying through staticfile build pack HOT 2
- Erroneous warning that nginx 1.21.x will no longer be supported in new buildpacks after 2022-05-25 HOT 2
- Release: staticfile-buildpack (Feb) HOT 1
- [QUESTION] When will staticfile-buildpack be available on cflinuxs4 stack? HOT 2
- Missing mime type for otf files (opentype fonts) ? HOT 5
- Release: staticfile-buildpack (Mar) HOT 1
- Ruby is not available in cflinuxfs4 HOT 1
- Release: staticfile-buildpack (Apr) HOT 1
- Release: staticfile-buildpack (May) HOT 1
- Release: staticfile-buildpack (Jun) HOT 1
- Release: staticfile-buildpack (Jul) HOT 1
- Release: staticfile-buildpack (Aug)
- Release: staticfile-buildpack (Sep) HOT 1
- Release: staticfile-buildpack (Oct) HOT 1
- Release: staticfile-buildpack (Nov) HOT 1
- Release: staticfile-buildpack (Dec) HOT 1
- Release: staticfile-buildpack (Jan) HOT 1
- Release: staticfile-buildpack (Feb) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from staticfile-buildpack.