Giter Site home page Giter Site logo

Comments (7)

cf-gitbot avatar cf-gitbot commented on August 16, 2024

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/128980925

The labels on this github issue will be updated when the story is started.

from staticfile-buildpack.

flavorjones avatar flavorjones commented on August 16, 2024

As I mentioned in the previous ticket, I'm not convinced that environment variables are the appropriate configuration mechanism.

from staticfile-buildpack.

flavorjones avatar flavorjones commented on August 16, 2024

I'd prefer for this to be configurable through the Staticfile

from staticfile-buildpack.

nertzy avatar nertzy commented on August 16, 2024

In my opinion the ideal situation for all settings is that you can set a default value in the Staticfile but that you could also override each of those settings with environment variables.

I could see someone wanting HSTS in public-facing production-like environments, but not in lower environments if they don't want the overhead of setting up SSL everywhere.

from staticfile-buildpack.

nertzy avatar nertzy commented on August 16, 2024

Depends on whether we consider each thing to be "internal application config" or not as per https://12factor.net/config.

from staticfile-buildpack.

jchesterpivotal avatar jchesterpivotal commented on August 16, 2024

My own opinion is that HSTS should be a switch in the Staticfile, not an environment variable. These

Environment variables are, ideally, only there to inject app behaviour. This buildpack blurs the line between app and buildpack, but I think we should maintain the distinction nonetheless. We broke this rule for FORCE_HTTPS, which we ought to deprecate, but in general we've remained consistent.

In particular, Staticfile does not build live applications. By extension from "environment variables are for apps", if there are no apps, there should be no environment variables.

Staticfile's particular brand of snowflakery is that there's no accepted ecosystem tooling and idiom that we're relying on to create and enforce conventions. For example, in Ruby, we don't "think" about these questions much -- we just delegate to Bundler and rubygems and let them set the policy for us.

While having no default idiom or packaging seems like freedom, it's also a scope magnet. I'm personally wary of adding multiple layers of configurability because we will have to entirely own the upkeep.

from staticfile-buildpack.

RochesterinNYC avatar RochesterinNYC commented on August 16, 2024

Closing as this has been implemented in e4efc9b

from staticfile-buildpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.