Discuss dev dependency gulp-gh-pages

[derekshirk]

Discuss dev dependency gulp-gh-pages

[tylersticka]

Maybe, maybe not. See #72 for history.

[calebeby]

Do we still need the demo functionality? (Is that a feature that is actually used?)

[calebeby]

Should I switch it from gulp-gh-pages to gh-pages? Should I try to switch it to deploy it to netlify?

[tylersticka]

Hmm... so I think what's happened is that when we launched Drizzle, the GitHub demo had to occupy a special gh-pages branch:

drizzle/gulpfile.js

Lines 48 to 58 in 6d53e7d

	/**
	* Register demo task (deploy output to GitHub Pages)
	* NOTE: Run this after building.
	*/
	gulp.task('demo', () => {
	const buildDest = `${config.drizzle.dest.pages}/**/*`;
	return gulp.src(buildDest)
	.pipe(ghPages({
	cacheDir: 'demo'
	}));
	});

While this is only necessary for the demo, I think it means we can't remove it unless we redo how the demo is sourced?

/CC @derekshirk @gerardo-rodriguez

[gerardo-rodriguez]

Should I try to switch it to deploy it to netlify?

@tylersticka @derekshirk I honestly can't remember if we'd shifted over to using Netlify around the time of #72. I wouldn't mind shifting it over to Netlify. Do either of you see a reason why we shouldn't do this?

/cc @calebeby

[tylersticka]

@gerardo-rodriguez We use Netlify on our projects, but the Drizzle demo is in GitHub pages: http://cloudfour.github.io/drizzle/

At the time, I think our logic was that there wasn't a need to add a separate hosting dependency for a simple demo. I also think it was when Netlify was young and maybe didn't have as nice of a free plan? I'm open to switching this up if we decide to host the demo elsewhere, as long as we make sure any links (not just here, but in our blog posts and stuff) are updated or redirected.

[calebeby]

So if we want to keep the demo functionality, and are fine with sticking to GitHub pages for it, I don't think there is a reason to remove the gulp-gh-pages dependency. Can I close this?

[gerardo-rodriguez]

as long as we make sure any links (not just here, but in our blog posts and stuff) are updated or redirected.

Good point @tylersticka. If I'm honest, this is something I wouldn't want to do unless it absolutely had to be done. 😬

So if we want to keep the demo functionality, and are fine with sticking to GitHub pages for it, I don't think there is a reason to remove the gulp-gh-pages dependency. Can I close this?

@calebeby This sounds correct to me.

[calebeby]

OK, closing