Giter Site home page Giter Site logo

Comments (9)

SilentImp avatar SilentImp commented on May 23, 2024 2

@anthumchris if I understand correctly the whole idea behind the hash in variables names is to restrict usage of variables that are not "officially" exposed.

Which is questionable approach.
Maybe owners can share why exactly it was done like that?

from components.

rubencarvalho avatar rubencarvalho commented on May 23, 2024 2

Hello Chris,
We currently donโ€™t allow the SASS dependency to be removed neither the randomising of hashes.
Weโ€™ve done this in order to guarantee backward compatibility.
To accept this as a feature request, we need to gather feedback about possible use cases to help us better understand and prioritise it.

from components.

just-boris avatar just-boris commented on May 23, 2024 1

Closing due to inactivity. Feel free to reopen if there are additional comments

from components.

anthumchris avatar anthumchris commented on May 23, 2024

If removing the SASS dependency isn't possible, can we simply remove the randomized hash strings from the generated CSS?

from components.

rubencarvalho avatar rubencarvalho commented on May 23, 2024

Hello Chris,

thank you for reaching out!

To better understand your use case, could you please share why you'd want to directly access the CSS variables?

If it is for theming reasons, please refer to the Theming documentation.

However, if your goal is to use our design tokens, these are available from a separate package called design-tokens and are intended to be used together with Cloudscape components. All of our tokens are available as SASS variables (e.g. $color-text-body-secondary) but also as JavaScript variables (e.g. colorTextBodySecondary).

Thanks!
RC

from components.

anthumchris avatar anthumchris commented on May 23, 2024

@rubencarvalho Thanks for your fast response. Could we kindly keep this thread focused on the technicality of the 2 aforementioned questions shown below? Let's avoid discussing or focusing on use cases for now, if you don't mind.

  1. Can we remove the SASS dependency to provide developers with direct, native usage of modern CSS variables?
  2. If removing the SASS dependency isn't possible, can we simply remove the randomized hash strings from the generated CSS?

from components.

arunim2405 avatar arunim2405 commented on May 23, 2024

Is it reasonable to ask for a config setting which lets us turn on or off hashed variables? If we strictly do not want to follow the Cloudscape Design guidelines but still would like to use the component library?
A very trivial usecase-
#408

from components.

just-boris avatar just-boris commented on May 23, 2024

What you are asking (changing a color of a button) is exactly the reason why there are hashes. Internal styles is not our public API, and we change them pretty often. Changing a color this way is not future proof and may lead to unexpected issues when doing a patch version upgrade

For the best development experience, it is better not to override our styles.

from components.

arunim2405 avatar arunim2405 commented on May 23, 2024

Understood, thanks for the clarification ๐Ÿ˜Š @just-boris

from components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.