Giter Site home page Giter Site logo

Comments (4)

ab18556 avatar ab18556 commented on May 22, 2024 5

I understand what you mean, but at the same time I think that Cloudscape should expose standard properties as much as possible. For example, the onChange is not providing the usual react event. It might bring a lot of issues with other libraries aswell. If Cloudscape is about design, why is it fiddling with the events and refs? why is value required even if it is empty?

from components.

just-boris avatar just-boris commented on May 22, 2024 3

Closing because this feature is not applicable to our project

from components.

just-boris avatar just-boris commented on May 22, 2024

This can be implemented in userland

import React from 'react';
import { Controller } from 'react-hook-form';
import { Input } from '@cloudscape-design/components';

export const ControlledInput = ({ name, control, ...props }) => (
  <Controller
    name={name}
    control={control}
    render={({ field: { ref, onChange, onBlur, value } }) => (
      <Input ref={ref} name={name} value={value} onBlur={onBlur} onChange={e => onChange(e.detail.value)} {...props} />
    )}
  />
);

You can wrap every control and publish it is a separate package

Having it built into library does not sound future proof, because what if somebody wants to use another form library

from components.

just-boris avatar just-boris commented on May 22, 2024

What you are asking sounds as a breaking change, but we are not planning on publishing a new major version in near future.

if you have any suggestion how to change API in a non-breaking way that may help you – let us know

from components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.