pre-commit: `PermissionError` while installing

[eggplants]

pre-commit: `PermissionError` while installing

[cmhughes]

https://github.com/csg-projects/latexindent-dockerfile

…

On Wed, 8 Jun 2022, 07:28 eggplants, ***@***.***> wrote: If I had a Dockerfile, I feel like I could run it with docker_image like pre-commit-shfmt <https://github.com/pecigonzalo/pre-commit-shfmt/blob/d9fbdb88841c1fe241aadff129167c323e394067/.pre-commit-hooks.yaml#L18-L33> and it would not fail with local permissions. — Reply to this email directly, view it on GitHub <#369 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ7CYENQBVPF2QB2VFWBWDVOA4RXANCNFSM5YFHPVSA> . You are receiving this because you commented.Message ID: ***@***.***>

[tdegeus]

I don't know what is going on, but I do think it might be more the pre-commit core that should be queried: the Perl package that poses problems might not even be a direct dependency of latenindent.

Regardless you could work around with the latexindent-conda hook, that use Conda's Perl

[eggplants]

• /home/eggplants/.cache/pre-commit/pre-commit.log

version information

pre-commit version: 2.19.0
git --version: git version 2.34.1
sys.version:
    3.10.4 (main, May 22 2022, 05:10:45) [GCC 11.2.0]
sys.executable: /home/eggplants/.pyenv/versions/3.10.4/bin/python3.10
os.name: posix
sys.platform: linux

error information

An unexpected error has occurred: PermissionError: [Errno 1] Operation not permitted: '/home/eggplants/.cache/pre-commit/repo95rn1aiq/perl_env-default/lib/perl5/LatexIndent/BlankLines.pm'

Traceback (most recent call last):
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/shutil.py", line 676, in _rmtree_safe_fd
    os.unlink(entry.name, dir_fd=topfd)
PermissionError: [Errno 13] Permission denied: 'BlankLines.pm'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pre_commit/error_handler.py", line 73, in error_handler
    yield
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pre_commit/main.py", line 389, in main
    return run(args.config, store, args)
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pre_commit/commands/run.py", line 414, in run
    install_hook_envs(to_install, store)
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pre_commit/repository.py", line 223, in install_hook_envs
    _hook_install(hook)
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pre_commit/repository.py", line 77, in _hook_install
    rmtree(hook.prefix.path(venv))
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pre_commit/util.py", line 257, in rmtree
    shutil.rmtree(path, ignore_errors=False, onerror=handle_remove_readonly)
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/shutil.py", line 722, in rmtree
    _rmtree_safe_fd(fd, path, onerror)
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/shutil.py", line 655, in _rmtree_safe_fd
    _rmtree_safe_fd(dirfd, fullname, onerror)
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/shutil.py", line 655, in _rmtree_safe_fd
    _rmtree_safe_fd(dirfd, fullname, onerror)
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/shutil.py", line 655, in _rmtree_safe_fd
    _rmtree_safe_fd(dirfd, fullname, onerror)
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/shutil.py", line 678, in _rmtree_safe_fd
    onerror(os.unlink, fullname, sys.exc_info())
  File "/home/eggplants/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pre_commit/util.py", line 253, in handle_remove_readonly
    os.chmod(p, os.stat(p).st_mode | stat.S_IWUSR)
PermissionError: [Errno 1] Operation not permitted: '/home/eggplants/.cache/pre-commit/repo95rn1aiq/perl_env-default/lib/perl5/LatexIndent/BlankLines.pm'

[cmhughes]

@Holzhaus @tdegeus any ideas?

[eggplants]

If I had a Dockerfile, I feel like I could run it with docker_image like pre-commit-shfmt and it would not fail with local permissions.

[eggplants]

Suggestion

- id: latexindent-docker
  name: latexindent.pl
  description: Run latexindent.pl (get dependencies using DockerHub)
  entry: csegarragonz/latexindent:0.0.1
  language: docker_image
  types: [tex]
  args: ["--overwriteIfDifferent", "--silent", "--local"]

[Holzhaus]

@Holzhaus @tdegeus any ideas?

The sudo prompt in the log is suspicious. It should not be necessary to input your root password. Possibly a misconfigured perl installation or some bug in pre-commit or maybe @eggplants ran pre-commit with sudo...

Anyway, I don't think this has anything to do with latexindent in particular.

[cmhughes]

Thanks for your work on docker @eggplants :)

I've released V3.18 https://github.com/cmhughes/latexindent.pl/releases/tag/V3.18

Are you happy if we close this issue?

[cmhughes]

@eggplants can you take a look at the error log at

https://github.com/cmhughes/latexindent.pl/actions/runs/3816377283/workflow

Any ideas what has gone wrong?

[cmhughes]

@eggplants please ignore my previous message, all resolved :)