CPC+: DateTimeParseException in the latest version but success in an earlier version

[cmsgov]

CPC+: DateTimeParseException in the latest version but success in an earlier version

[halprin]

Nice catch! And yeah, I think that changing EnvironmentHelper to also return the default on an empty string is appropriate, @aaroalan.

[sfradkin]

@nathandonato We have deployed a new version of the converter to production. Please try it out and see if that gets your file converted and submitted.

[aaroalan]

Looks like the issue is a missing env var CPC_END_DATE, CpcClinicalDocumentValidator.java has this line LocalDate.parse(EnvironmentHelper.getOrDefault(END_DATE_VARIABLE, NEVER_ENDING)) but looks like it's returning an empty string instead of the defaultValue.

You can fix it locally if you se the env var in the docker-compose.test.yaml

...
environment:
  - CPC_END_DATE=3000-01-01
...

[aaroalan]

Update: Don't need to update the docker-compose file .env file has CPC_END_DATE= so that's why var is ''

[sfradkin]

We'll double check the documentation to ensure that this is called out in the docs as an env var to modify. We can also just provide a default value in the .env file.

[aaroalan]

Maybe the EnvironmentHelper should validate that value is not null and is not a empty string, What do you think?

[sfradkin]

@aaroalan @nathandonato: We have added this issue to our backlog and it will be prioritized today. We will let you know via this issue when changes have been made.

[nathandonato]

Thanks @sfradkin! I'm sure you're aware and will factor this into the priority, but it's probably worth overstating: CPC+ submissions are due in one week (2018-02-28).

[sfradkin]

@nathandonato Yes we are aware of this. However, since there is a stated solution in this thread as to how to set the environment variable, and there is a publicly available sandbox at https://qpp.cms.gov/developers/conversion-tool-sandbox that uses our production code, that lowers the priority of this a bit.

[nathandonato]

That makes sense, thanks for the follow up. But we are getting this error when doing QRDA III XML submissions (we assume this is the error; the response is error code 3, and this is the actual exception we get locally for the same file).

So we can use the environment variable solution in our testing, but is there any chance you guys will set the environment variable in production?

[sfradkin]

Ah, sorry. I missed the part that you tried this as a real submission and got the same error. I can confirm that I am seeing that error with your file. We'll take a look at this to see what's going on as it's unrelated to the CPC_END_DATE.

[nathandonato]

Sorry, that's my fault. I should have been more clear. Thanks for looking into it.

[sfradkin]

@nathandonato Looking at this further it appears that you have a missing code in one of your supplemental data elements. We are already working on a fix for this situation so that it correctly outputs an error with the xpath rather than returning an "unexpected error". It's tough to eyeball the QRDA document to find the missing code, but that's where you can look.

We're going to work on getting this fix out as a hotfix to production by the end of the day tomorrow.

[nathandonato]

@sfradkin We believe we found the issue. Thanks for pointing us in the right direction!

[sfradkin]

With no response for over a week, I'm going to go ahead and close this issue as fixed.