Comments (7)
Jet::IsTagged is used once in https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/SKFlatValidation.C#L161.
It's okay to use for 2017, but it returns wrong result for other than 2017.
After changing that part like ExampleRun.C, we can remove Jet::IsTagged and FatJet::IsTagged.
If you guys agree with that idea, I could make a pull request.
(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/Jet.C#L126-L180)
(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/FatJet.C#L140-L194)
from skflatanalyzer.
I think this is ok to make the pull request.
from skflatanalyzer.
You can update
SKFlatAnalyzer/data/Run2Legacy_v1/2017/BTag/taggermap.txt
Lines 1 to 10 in 3d54d9a
from skflatanalyzer.
These files should be up to date, if not you should update the values/taggers and make a PR.
To use it in your code, you can follow the recipe in Example run.
https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/ExampleRun.C#L48
https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/ExampleRun.C#L336
Maybe the function in Jet class can be removed tio avoid confusion.
from skflatanalyzer.
Please check #37
from skflatanalyzer.
Please check #37
it looks good!
from skflatanalyzer.
#37 merged.
from skflatanalyzer.
Related Issues (11)
- Adding BTagSF HOT 1
- Adding 2016 PU reweight HOT 2
- Job directory size is large HOT 1
- BTagSF for 2018 and 2016 available HOT 2
- Adding important analyzers into the master branch HOT 1
- New JEC for 2018 DATA: Autumn18_V8 HOT 1
- [BTag] FastSim to FullSim corrections updated for all years HOT 2
- [Sample 2018] Can we add Wjets for the next production?
- [xsec]
- Moving Run2UltraLegacy to master HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skflatanalyzer.