Giter Site home page Giter Site logo

Comments (7)

bhoh avatar bhoh commented on September 4, 2024 1

Jet::IsTagged is used once in https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/SKFlatValidation.C#L161.
It's okay to use for 2017, but it returns wrong result for other than 2017.
After changing that part like ExampleRun.C, we can remove Jet::IsTagged and FatJet::IsTagged.
If you guys agree with that idea, I could make a pull request.

(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/Jet.C#L126-L180)
(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/FatJet.C#L140-L194)

from skflatanalyzer.

jalmond avatar jalmond commented on September 4, 2024 1

I think this is ok to make the pull request.

from skflatanalyzer.

jedori0228 avatar jedori0228 commented on September 4, 2024

You can update

### taken frmo https://twiki.cern.ch/twiki/bin/viewauth/CMS/BtagRecommendation94X on 29 Jan 2019
2017 CSVv2 Loose 0.5803
2017 CSVv2 Medium 0.8838
2017 CSVv2 Tight 0.9693
2017 DeepCSV Loose 0.1522
2017 DeepCSV Medium 0.4941
2017 DeepCSV Tight 0.8001
2017 DeepFlavour Loose 0.0521
2017 DeepFlavour Medium 0.3033
2017 DeepFlavour Tight 0.7489
and try to use BTagSFUtil I think..?

from skflatanalyzer.

jalmond avatar jalmond commented on September 4, 2024

These files should be up to date, if not you should update the values/taggers and make a PR.

To use it in your code, you can follow the recipe in Example run.

https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/ExampleRun.C#L48

https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/ExampleRun.C#L336

Maybe the function in Jet class can be removed tio avoid confusion.

from skflatanalyzer.

jedori0228 avatar jedori0228 commented on September 4, 2024

Please check #37

from skflatanalyzer.

bhoh avatar bhoh commented on September 4, 2024

Please check #37

it looks good!

from skflatanalyzer.

jedori0228 avatar jedori0228 commented on September 4, 2024

#37 merged.

from skflatanalyzer.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.