Giter Site home page Giter Site logo

"bug" in player.max_mmr about siegeapi HOT 5 CLOSED

Xample33 avatar Xample33 commented on June 1, 2024
"bug" in player.max_mmr

from siegeapi.

Comments (5)

CNDRD avatar CNDRD commented on June 1, 2024

That's a weird thing..
Since that's only supposed to happen when Ubi doesn't return the previous rank mmr and the next rank mmr (basically any case, other than ranked..)

if self.prev_rank_mmr == 0 and self.next_rank_mmr == 0:
self.rank, self.prev_rank_mmr, self.next_rank_mmr, self.rank_id = _get_rank_from_mmr(self.mmr)
self.max_rank_id = self.max_mmr = -1
self.max_rank = "Undefined"

Ubisofts API is so stupid it could very well be a one-off case
But, I personally, am using this library daily to grab data for ~10 users every 30 minutes
Never seen that happen

So if you could provide me with the account name you're using so I could investigate further
(Or any other that has only one game played; I ain't searching for one)

(I also don't know why I decided to return -1 and not 0, imma fix that in the next release probably)

from siegeapi.

Xample33 avatar Xample33 commented on June 1, 2024

Maybe you can just set the return to 0 instead of -1.
But the username is Xampl3_ (mine), and i have played only one ranked game in this season.

from siegeapi.

CNDRD avatar CNDRD commented on June 1, 2024

I can definitely do that, that isn't a problem
This just isn't supposed to happen when you want ranked stats...

from siegeapi.

Xample33 avatar Xample33 commented on June 1, 2024

yeah yeah

from siegeapi.

CNDRD avatar CNDRD commented on June 1, 2024

I have pushed the updated code that correctly returns 0 when calling .load_ranked()
Along with a new v4.1.5 release on GitHub releases & PyPI

This definitely wasn't happening in the past so thanks for letting me know

from siegeapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.