Giter Site home page Giter Site logo

Comments (6)

mr-karan avatar mr-karan commented on August 24, 2024 1

As a "hacker", you can always deminify if you want to edit. I think you should minify it definitely, more so if the performance increase is whopping 50%

from coala-html.

gitmate-bot avatar gitmate-bot commented on August 24, 2024

Thanks for reporting this issue!

@coala-analyzer/coala-contributors, your aid is required, fellow coalaian. Help us triage and solving this issue!

from coala-html.

AbdealiLoKo avatar AbdealiLoKo commented on August 24, 2024

I don't see 30kb to be much.
If you really want to save on bandwidth, then you would want to remove bower, and just serve the angular.min.js and bootstrap.min.css - as those will reduce the downloads required by much more than 30kb

BTW: when you calculated 20-30kb, did you compare the final pypi packages ? Or the minified js file vs the non minified one ? Because the tar.gz compression python setup.py sdist does will reduce that number further I think.
Also, if you want to further decompress it, consider making a python wheel ^_^ And also, reducing the number of files (i.e. move all controllers to one file, etc.)

from coala-html.

tushar-rishav avatar tushar-rishav commented on August 24, 2024

@AbdealiJK
A. Yeah. 30kbs isn't a lot. But I thought why not save those 30kbs if we could do it. My thought was to minimise the overall size of the angular package. Now I think bower is necessity here? Packaging with angular files would further increase the size - by few kbs. Moreover, we will be getting the updated dependencies via bower. I don't see any other PROs of using bower. Should we remove bower and go with packaging static dependencies along with binary package? Hm it's debatable.
B. For now I have just considered js files. So the reduction of 20-30 kbs is because of js+html files only.

But yeah I think sdist will do that dirty work significantly. So I think maybe we could just leave for now. Not sure if it's wise.

from coala-html.

AbdealiLoKo avatar AbdealiLoKo commented on August 24, 2024

I'd say keep it low priority - after your gsoc deliverables are done

from coala-html.

Makman2 avatar Makman2 commented on August 24, 2024

but if you access the page a 1000 times, 50kb -> 50mb
but I agree with @AbdealiJK , low priority, first get things to work, then optimize :)

from coala-html.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.