Giter Site home page Giter Site logo

Comments (6)

minggo avatar minggo commented on July 19, 2024

I think it is because engine source code also has the folder named native, and the generated folder also has a native folder.

from cocos-engine.

smallmain avatar smallmain commented on July 19, 2024

I think it is because engine source code also has the folder named native, and the generated folder also has a native folder.

Okay.

In my case, my engine plugin will have the native directory because the installed npm package has a directory with that name, but the engine plugin will have to add node_modules to Git if it's going to work properly because of this unresolved issue: #16896

Then, the project directory also has a directory with this name:

  • assets
    • login-sdk
      • native
      • browser
      • minigame

from cocos-engine.

minggo avatar minggo commented on July 19, 2024

May be you should ask the plugin user to remove it. As most developers will not modify engine codes, so i think it is reasonable to keep it.

from cocos-engine.

smallmain avatar smallmain commented on July 19, 2024

May be you should ask the plugin user to remove it. As most developers will not modify engine codes, so i think it is reasonable to keep it.

What? no!

The engine code has not been modified!

  • extensions
    • plugin-a
      • node_modules
        • fs
          • dist
            • impls
              • native
                • index.js
              • web
              • other

Here I assume that the engine plug-in depends on a cross-platform file system implementation module.
Because of the gitignore file, users cannot simply put plugins into version management.

This situation is not uncommon!

from cocos-engine.

minggo avatar minggo commented on July 19, 2024

In my project, the .gitignore is

#///////////////////////////
# Cocos Creator 3D Project
#///////////////////////////

/library/
/temp/
/local/
/build/
/profiles/
/native/engine/android/**/*/assets

It is different from you.

from cocos-engine.

smallmain avatar smallmain commented on July 19, 2024

I tried creating a new project using 3.8.3 and the .gitignore is:

#///////////////////////////
# Cocos Creator 3D Project
#///////////////////////////
library/
temp/
local/
build/
profiles/
native
#//////////////////////////
# NPM
#//////////////////////////
node_modules/

#//////////////////////////
# VSCode
#//////////////////////////
.vscode/

#//////////////////////////
# WebStorm
#//////////////////////////
.idea/

The same problem just occurred in the my team. I added the l10n plug-in to the project and submitted it to git. An error occurred after the team member pulled it.

image

because gitignore ignores node_modules, but the current plug-in system cannot automatically install plugin's dependencies.

I think the default gitignore file needs to be completely improved, and try to only ignore directories that Creator must ignore, rather than hitting it on a large scale.

In addition, Some settings of Creator itself are also ignored. things like build settings should be synchronized by default.

from cocos-engine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.