Comments (3)
Blocked by #12
from deprecated-code-corps-rails-api.
Based on how #12 is being implemented, we could go in multiple directions with this one. If we want simple RESTful routes, then we'd need
First approach
POST /contributors
- This one creates a new Contributor record, withproject
set to provided project,user
set tocurrent_user
andstatus
set to "pending". It can be accessible by any logged in user.PATCH /contributors
. This one takes an existingContributor
record and sets its status to some other value. At first, it can be used by an admin or owner to approve a pendingContributor
record. Later, it can also be used to change contribution levels (the value ofstatus
) for other contributors as well.
This first approach gives more flexibility, but also puts some responsibility on the client. When the user clicks on "apply for a contributor" (or whatever they click on), the client app will need to know this means creating a new contributor record with project
set to the project currently being viewed.
Second approach
We have routes such as
POST /projects/:id/apply_for_collaboration
(or some other similar route)- `POST /contributors/:id/approve,
POST /contributors/:id/promote
- etc.
The actions are more atomic this way and the routes are more verbose and descriptive, but I'm not really sure the client will be able to be dumber this way, especially an ember client.
Due to that, I'll go with the first approach for now, but I can shift to the second if necessary.
from deprecated-code-corps-rails-api.
@joshsmith I believe this was handled by #70. We now have a POST /contributors
route, which enables joining a project.
However, I believe we should change this route so it's nested under the project - POST /:member_slug/:projet_slug/contributors
to maintain consistency. I'm creating a new issue to address this and closing this one - #107
from deprecated-code-corps-rails-api.
Related Issues (20)
- Document User Categories API HOT 1
- Document User Roles API
- Document User Skills API
- Document Users API HOT 1
- Clarify that bin/setup must be run in new terminal window
- Find a way to deploy branch commits HOT 2
- Add ability to assign tasks HOT 1
- Reference GitHub repositories in a project HOT 1
- Reference GitHub repositories in a post HOT 1
- Add project updates to projects HOT 1
- Add GitHub authentication HOT 1
- Connect GitHub repositories to projects HOT 1
- Add the ability to push to Apiary in Circle HOT 2
- Documentation - Issue with credential exchange
- RFC - API Documentation Guidelines HOT 9
- Change wording in role skills
- Make changes suggested by API Blueprint linter
- Find better way of documenting coalesced ids
- Rework User Skills and Role Skills to remove "join table" references
- Fix project#create to respond according to JSON API spec
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deprecated-code-corps-rails-api.