Giter Site home page Giter Site logo

Comments (4)

jeffreybiles avatar jeffreybiles commented on July 23, 2024

Hey @bradocchs,

Glad you enjoyed the course! And thanks for pointing out the ending branches.

It appears that some of the issues caught and fixed in lesson 14 stretch back a ways, so I've updated the ending branches so clicking on an email opens the modal correctly.

I also just pushed the course-end branch, which should be identical to the video-15-end branch except for a commit where I remove extraneous code.

Let me know if there's anything else that comes up!

from build-gmail-clone-with-vue-3.

bsataric avatar bsataric commented on July 23, 2024

Hello @jeffreybiles and thanks for a very nice course!

I've also had some issues starting from lession 4.

Apparently when clicking on an email row in lession 4 the "read" property seems to change (I tried logging it) but the styling of the row remains the same no matter if I use your code (global styling) or I try to put styling inside the table component. The "read" row just stays white all the time and never changes to gray.

Same happens with archived click, it just doesn't hide the archived rows.

This doesn't happen without async (with static data - lession 3 start) so I'm not sure what might be the issue.

I tried lession 15 end just to see what happens and it seems that all works but I would like to know what causes these row problems in lession 4.

Thanks in advance!

Bogdan

from build-gmail-clone-with-vue-3.

bsataric avatar bsataric commented on July 23, 2024

Oh I found the reason for my troubles. It is the ref() around emails and openedEmail fileds inside ModelTable.vue.

However this hasn't been added until the lession-6-end branch so maybe that should be fixed for the prior lessions.

from build-gmail-clone-with-vue-3.

sholmas avatar sholmas commented on July 23, 2024

This was a great course, with easy-to-follow steps to understand async setup and Suspense. This might belong elsewhere, but it would be great to have a final example with unit tests as well, as Suspense and async setup is not well covered by other unit testing guides (and ususally crashes because the component is null).

Hope you find the time to cover this in a future lesson!

from build-gmail-clone-with-vue-3.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.