Giter Site home page Giter Site logo

Contributing guide about laravel-jwt HOT 7 CLOSED

codecasts avatar codecasts commented on May 26, 2024
Contributing guide

from laravel-jwt.

Comments (7)

hernandev avatar hernandev commented on May 26, 2024

You can include a PR that adds a CONTRIBUTING.md on the root folder, but also, it should go to develop.

Only git flow can change the master branch directly.

from laravel-jwt.

hernandev avatar hernandev commented on May 26, 2024

Thanks!

from laravel-jwt.

flyingluscas avatar flyingluscas commented on May 26, 2024

Great! I'll prepare a new PR for this tomorrow :)

from laravel-jwt.

hernandev avatar hernandev commented on May 26, 2024

Thanks

from laravel-jwt.

flyingluscas avatar flyingluscas commented on May 26, 2024

@hernandev I think it would be a good idea to make develop as the main branch, that way new pull requests go directly to it, what you think?

from laravel-jwt.

hernandev avatar hernandev commented on May 26, 2024

Included Hacktoberfest label on some issues and PR, so you can all enjoy the perks of the promotion, check more about it here: https://hacktoberfest.digitalocean.com/

from laravel-jwt.

hernandev avatar hernandev commented on May 26, 2024

Actually that's not even needed anymore, just figured it out.

@flyingluscas making develop default branch has implications on gitflow command line, since it may detect wrongly the production branch as being develop, since it's the default one.

I've just find out I can change the base branch on pull requests so that's not even a problem anymore, I can just change the branch when it comes to the wrong one.

For now, thanks for the contributing guide.

from laravel-jwt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.