Giter Site home page Giter Site logo

Comments (4)

drazisil-codecov avatar drazisil-codecov commented on September 12, 2024 1

It appears that the glob library this project uses calls minimatch under the hood for this functionality. minimatch could be added as a direct dependency for its match functionality.

minimatch does appear to be quite old; however:

  • It appears to be quite mature
  • It is written by one of the founders of npm (the former BDFL, in fact)

So is Glob :D. I'm not adverse to the change, at the time I was the only dev and I understand glob, not so much how to use minimatch. I'd love to look at a PR, since it's not broken right now it's going to be lower priority If I need to do it

from uploader.

drazisil-codecov avatar drazisil-codecov commented on September 12, 2024

Line https://github.com/codecov/uploader/blob/master/src/helpers/files.js#L179 will likely need glob to expand the masks.

from uploader.

RA80533 avatar RA80533 commented on September 12, 2024

It appears that the glob library this project uses calls minimatch under the hood for this functionality. minimatch could be added as a direct dependency for its match functionality.

minimatch does appear to be quite old; however:

  • It appears to be quite mature
  • It is written by one of the founders of npm (the former BDFL, in fact)

from uploader.

mitchell-codecov avatar mitchell-codecov commented on September 12, 2024

Fixed in #276

from uploader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.