Optimize PHP Dockerfile with multistage builds (builder pattern)

[codelytv]

Optimize PHP Dockerfile with multistage builds (builder pattern)

[fiunchinho]

Having a Dockerfile on the root of the project allows potentials developers to just docker build and docker run the repository, without having to know where the hell the Dockerfile is. I don't see how adding one more file to the root of the project adds noise.

[JavierCane]

First attempt:

FROM composer as builder

COPY composer.json composer.lock /app/
RUN composer install  \
    --ignore-platform-reqs \
    --no-ansi \
    --no-autoloader \
    --no-interaction \
    --no-scripts

COPY . /app/
RUN composer dump-autoload --optimize --classmap-authoritative

FROM php:7.2-fpm-alpine
WORKDIR /app

RUN pecl install amqp apcu xdebug-2.6.0 \
    && docker-php-ext-enable xdebug \
    && docker-php-ext-install pdo pdo_mysql

COPY --from=builder /app /var/www/
COPY php.ini xdebug.ini /usr/local/etc/php/

[JavierCane]

PR opened moving the PHP Dockerfile to the root directory: #63

We can go ahead with this approach by the moment. However, when I was referring to the fact of adding more noise because of adding this Dockerfile to the root directory, I was thinking about adding different Dockerfile-whatever in a near future. We could end up having different PHP Dockerfiles depending on the environment (not installing dev dependencies neither generating the dev classes autoload classsmap), so it could end up being a little mess not being able to group these files into a subfolder.

At the end of the day, we're using Docker Compose, so if we want to locate where the Docker magic happens, we would always have the docker-compose.yml in the root directory 🙂

[JavierCane]

Issue closed by PR: #63