Comments (2)
That's an interesting concept. It might require a new parameter like "size_by_complexity: false" which is defaulted to false.
The complexity though is a bit subjective. Would you judge based on the lines added per file relative to the original files size? Or just the total number of files touched in general?
There are code complexity algorithms that a user might assume are being used if this param is enabled such as cognitive complexity which is used by CodeClimate.
from pr-size-labeler.
Good thoughts. Well as you probably already have seen, I took a simple approach with the amounts of file being touched, as in my perception, it doesn't matter if there is 1 line change or 30 in a single file. What for me seems to increases the complexity is the context switch from file to file. Might be subjective though. I hear that you'd prefer to use the changed line/total line ratio?
Also the naming should be clear that is not about "code complexity" as it is not a static code analysis.
Disclaimer: I'm surly not that common with shell scripts :)
from pr-size-labeler.
Related Issues (20)
- Subtle bug 🔥 in support for ignoring files !? HOT 7
- Ignore files and folders by pattern? HOT 7
- Not working anymore HOT 11
- PR size labeler is not working HOT 2
- Is it possible to make github bot as labeler? HOT 2
- Label is not added pull requests HOT 1
- Feature Request: Regular expression support for files_to_ignore parameter HOT 5
- Document required permissions HOT 5
- XL warning message is posted repeatedly HOT 2
- Allow messages per size definition
- A new release with regex support HOT 2
- Possible to not pass message_if_xl? HOT 2
- Add support to ignore whitespace-only changes? HOT 1
- can ignore deletions? HOT 2
- Action fails: parse error: Invalid numeric literal at line 1, column 6 HOT 7
- Labeling nonexist size level `size/xs`
- Is it possible to ignore line count from deleted files? HOT 2
- files_to_ignore HOT 3
- Proposal to Revive and Maintain Pr-Size-Labeler: Seeking Community Input HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pr-size-labeler.