Comments (4)
@nimit95 @piyush6348 What do you think? 😄
from data-structures-algorithms.
yeah happy to accept changes :)
from data-structures-algorithms.
OK, I thought about some points for each PR:
Pull Requests
We need to identify category, algorithm and language.
-
I suggest all new PRs need to be titled with a model, like
category: algorithm (language)
.
Ex1:Sorting: Bubble Sort (C)
Ex2:Searching: Binary Search (Java)
This model could be extended to include implementation name. -
The PR template should contain checkboxes for the definitions from CONTRIBUTION.md, so the contributor vouches that his changes follow the guidelines, which saves time on code reviews.
-
PRs should be single commit only. You should squash all commits into one and then submit your changes, so it's easier to handle the code history.
License
- OK to insert the MIT license or you have other plans?
from data-structures-algorithms.
Yeah, all these things seem fine, can you change in readme and contribution.md and make a pull request?
from data-structures-algorithms.
Related Issues (20)
- Selection sort HOT 1
- Quick Sort Algorithm HOT 1
- Floyd Warshall's Algorithm
- Bellman Ford's Algorithm
- Four sum
- Search Rotated Sorted array
- Rainwater trapping problem
- Largest rectangle in histogram
- Bubble Sort in C++ HOT 2
- Quick Sort in JavaScript
- Detecting Cycle In A Directed Graph [Python]
- Add Interview Prep resources
- Strongly Connected Component algorithm (C++)
- Check for cycle in Graph (C++) HOT 2
- Buy And Sell Stocks 3
- Best Time to Buy and Sell Stock
- Buy & Sell stocks 2
- First & Last element in a rotated sorted array. HOT 1
- RabinKarp String hashing algorithm in C++ HOT 1
- .
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data-structures-algorithms.