Comments (3)
Feel free to create this. I'm not up on how it works and I'm slammed for time.
from toastr.
Thanks @johnpapa. Two things are required on your end:
- Using SemVer versioning i.e. #42 and
- Pushing tags of each version to GitHub eg "v1.1.5"
I should be able to take care of the balance.
Cheers
from toastr.
I see that you've decided to rename toastr.js
to toastr-1.1.5.js
.
I'd like to recommend against doing this because it's going to cause problems for automated builds that use Bower. Essentially this makes extra work for consumers of toastr
because in addition to bumping the toastr version in the projects component.json
, any includes now have to change, whether they're RequireJS based or inline script tags.
We're consuming about a dozen packages in Bower, and the approach you've taken is definitely not the norm.
In our case, we're using a combo of Grunt and RequireJS to handle dependency management, and this requires two mods to our source to bump toastr versions, instead of the just one of other packages.
I'll send a PR for the component.json
-- the toastr.js
file is referenced there as well, so having the script named with a version attached adds work for you at each version bump as well.
from toastr.
Related Issues (20)
- ngx toastr clear on outside click of toastr area
- Add import without links necessity HOT 3
- Travis-CI did not trigger tests
- Correlate a Toast with the one which has Just Hidden HOT 1
- jQuery.easing[jQuery.easing.def] is not a function
- Cannot read property 'extend' of undefined HOT 1
- Can't put two toastrs at two different positions
- timeOut not working
- timeout=0 onclick=function(){} how do I hide the toastr? HOT 1
- Accessibility issues HOT 1
- setAria
- #558 require js loading issue
- XSS Vulnerability "HIGH" due to default escapeHtml=false setting HOT 5
- TypeError: Cannot read properties of undefined (reading 'extend') HOT 2
- Toastr background white HOT 1
- toastr does not work with bootstrap 5 ? HOT 2
- This project is not maintained (2023)
- Target class [toastr] does not exist. HOT 1
- Update a toast message if a toast is already visible
- Icon animation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toastr.