Giter Site home page Giter Site logo

Comments (3)

johnpapa avatar johnpapa commented on July 17, 2024

Feel free to create this. I'm not up on how it works and I'm slammed for time.

from toastr.

brianmhunt avatar brianmhunt commented on July 17, 2024

Thanks @johnpapa. Two things are required on your end:

  1. Using SemVer versioning i.e. #42 and
  2. Pushing tags of each version to GitHub eg "v1.1.5"

I should be able to take care of the balance.

Cheers

from toastr.

Iristyle avatar Iristyle commented on July 17, 2024

I see that you've decided to rename toastr.js to toastr-1.1.5.js.

I'd like to recommend against doing this because it's going to cause problems for automated builds that use Bower. Essentially this makes extra work for consumers of toastr because in addition to bumping the toastr version in the projects component.json, any includes now have to change, whether they're RequireJS based or inline script tags.

We're consuming about a dozen packages in Bower, and the approach you've taken is definitely not the norm.

In our case, we're using a combo of Grunt and RequireJS to handle dependency management, and this requires two mods to our source to bump toastr versions, instead of the just one of other packages.

I'll send a PR for the component.json -- the toastr.js file is referenced there as well, so having the script named with a version attached adds work for you at each version bump as well.

from toastr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.