Comments (3)
I'm not sure where that setting is or why its causing a problem. Can you elaborate?
from toastr.
Same problem. Unusable in production with Express.js + UglifyJS2, since UglifyJS2 as of the current released version (https://npmjs.org/package/uglify-js) can't handle BOM files (see mishoo/UglifyJS#402).
BOM or Byte order mark is the way many Windows system are saving UTF8 files (https://en.wikipedia.org/wiki/UTF-8#Byte_order_mark). Toaster files however do have BOM-UTF8:
~/develop/kati/bower_components/toastr master grep -rl $'\xEF\xBB\xBF' .
./toastr.css
./toastr.js
./toastr.min.css
./toastr.min.js
This is in general a bad practice to use exotic or OS-specific encoding. I would appreciate if you could re-save the files in plain UTF8. The simplest way to accomplish that:
awk '{if(NR==1)sub(/^\xef\xbb\xbf/,"");print}' toastr.js > tmp.js
mv tmp.js toaster.js
# The diff would look like that:
diff --git a/bower_components/toastr/toastr.js b/bower_components/toastr/toastr.js
index 67dac2e..b491e26 100644
--- a/bower_components/toastr/toastr.js
+++ b/bower_components/toastr/toastr.js
@@ -1,4 +1,4 @@
-<U+FEFF>/*
+/*
* Toastr
* Version 2.0.1
* Copyright 2012 John Papa and Hans Fjällemark.
If you like I could create a PR for this.
from toastr.
oh sorry I don't replied, I totally forgot to this issue
@kostia is right (thanks for detailed description), I solved it with pre-compillation filter in my assets management system which removes all BOMs from files, but I think this is problem anyway
from toastr.
Related Issues (20)
- ngx toastr clear on outside click of toastr area
- Add import without links necessity HOT 3
- Travis-CI did not trigger tests
- Correlate a Toast with the one which has Just Hidden HOT 1
- jQuery.easing[jQuery.easing.def] is not a function
- Cannot read property 'extend' of undefined HOT 1
- Can't put two toastrs at two different positions
- timeOut not working
- timeout=0 onclick=function(){} how do I hide the toastr? HOT 1
- Accessibility issues HOT 1
- setAria
- #558 require js loading issue
- XSS Vulnerability "HIGH" due to default escapeHtml=false setting HOT 5
- TypeError: Cannot read properties of undefined (reading 'extend') HOT 2
- Toastr background white HOT 1
- toastr does not work with bootstrap 5 ? HOT 2
- This project is not maintained (2023)
- Target class [toastr] does not exist. HOT 1
- Update a toast message if a toast is already visible
- Icon animation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toastr.