Ghost Ping not detected on message edit

[BlackBearFTW]

Ghost Ping not detected on message edit

[theboxmage]

Now that I have a real keyboard.
I'm advocating for either a new handler or an update to the LogUpdateMessageHandler. A new GhostPingUpdateHandler (name pending) is more verbose and probably fits better in our design pattern. This would sit on the Message Update event, which gives two params when it resolves.

The other, lazier, option is to jam it into the existing LogUpdateMessageHandler.

I'd be willing to look at either option, but a new handler feels like the safer better choice.

[olivier-b-be]

What's the preferred way in your eyes to change this? The EventHandler only takes in one argument in the constructor which is specifically for the delete event, I'm sure the update also needs some slightly different code but considering the name currently is GhostPingHandler it seems like it has everything to do with any form of ghost pings

[theboxmage]

Messages have a mentions object, just check to see if all the elements in the old message are the same as the new.

[olivier-b-be]

GhostPingUpdateHandler seems good to me, do I rename the current GhostPingHandler to GhostPingDeleteHandler?

[theboxmage]

Sure, that sounds like a reasonable change to make.