Comments (10)
I highly recommend a file committed to the repository.
from pr-agent.
Hi @okotek i can work on this and #157, make it configurable for those who wish make any of this automatically
I am thinking about put it in settings/configuration.toml
[pr_reviewer]
automatic_describe=false
automatic_review=false
automatic_improve =false
and then use it in relevant places
if you want me to help here I'll be happy to take it
Best regards
Ilya
from pr-agent.
I implemented an automatic_review
setting in our fork because I wanted to install the app for all repos, but allow individual repos to opt into reviews. I can open a PR with the changes if that would be helpful.
from pr-agent.
Sorry, I had unexpected changes in my startup and wasn't active here last week+
is this still open, or would we love to go with @tjwp PR?
from pr-agent.
yes
https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app
https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-action
from pr-agent.
The difficulty here is that the same GitHub app needs to be configured differently for different installations, and they all share the same configuration files. We could do:
- Some persistence of settings per installation, need to be defined and decide how to manipulate. (/config command? Dedicated endpoint?)
- A user might commit a specially named file into their repository (.pr_agent) with settings that will override the default.
- A command embedded in the PR title :(
Any other ideas?
from pr-agent.
so we will go with special file, i'll start work on it and update
from pr-agent.
hi
it took little bit more time to get into it that i planned and i've started today.
when i build my test environment i recognized as as per current readme for setup github app we not require setup permission to read repo so we can see only files with included in PR not special file which probably will be setup once and not change too match
in github app this approach won't work, unless i missed something
setting per installation probably also not good idea for big project devops team will setup it once and developers won't be able to change it later, for small setups when devs do everything alone it better idea
command or keyword embedded in PR ugly but works for any cases.
also original esauser idea for new command for all 3 maybe nice path, but unless we want put this new command as default instead /review i don't see how it can help
bottom line i only see command or keyword embedded in PR can be possible solution, but would like to see what do you guys think
Best regards
Ilya
from pr-agent.
@idavidov have you seen the work done here? At a minimum, it seems like there ought to be a way to have a single command they always runs and then determines what to do based on the config. Unless maybe this doesn't actually work as described? #155
from pr-agent.
Is it possible to do this (automated /review --extended) with Github Actions?
from pr-agent.
Related Issues (20)
- Manual execution not possible with workflow_dispatch HOT 1
- Bitbucket pipeline fails HOT 1
- TypeError: catching classes that do not inherit from BaseException is not allowed HOT 5
- [Feature Request] Convert logging configuration to use loguru-config HOT 2
- [HELP] Error: name 'GithubProvider' is not defined HOT 2
- The docker build target must be gitlab_webhook for local gitlab install HOT 1
- Avoid circular code suggestions. HOT 2
- GitHub Actions fail when using Azure OpenAI's gpt-4 HOT 13
- Gitea Support HOT 3
- Do not hard code `github.com` checking HOT 2
- /improve tool fails for Azure DevOps integration HOT 6
- Pin Docker Image Versions in GitHub Actions HOT 11
- Self-host Github App is not working with Github Enterprise Server HOT 1
- Use `instructor` for Parsing and Validation HOT 5
- Unable to Specify AWS Bedrock Region HOT 4
- Error Handling Improvements
- There is support for gpt4 o mini? HOT 2
- Add Model Hyperparameter Configuration HOT 2
- [Feature Request] Support OpenAI seed parameter HOT 2
- Bitbucket Server link to lines in file missing HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pr-agent.