Giter Site home page Giter Site logo

Comments (13)

okotek avatar okotek commented on July 22, 2024 1

#181
@mrT23 can you review?

from pr-agent.

krrishdholakia avatar krrishdholakia commented on July 22, 2024

Hey @okotek were y'all able to get this - it's the force_timeout param

Happy to make a PR if required.

from pr-agent.

zmeir avatar zmeir commented on July 22, 2024

Was addressed in #181 as far as I can tell, although even with 180 seconds I'm still seeings timeouts with large PRs. I'll try creating a reproducible example.

from pr-agent.

krrishdholakia avatar krrishdholakia commented on July 22, 2024

Hmm.. maybe we can remove timeouts from lite / make that an optional parameter, this should prevent these scenarios from occurring.

This was primarily added to deal with Azure / Replicate related issues where the model calls would hang for an unusual amount of time.

from pr-agent.

krrishdholakia avatar krrishdholakia commented on July 22, 2024

Ok, tracking this on our end - BerriAI/litellm#73

Will aim to have an updated version tested + pushed out by EOD. I'll make a PR for the change, which can then run through the normal testing y'all have for PR-Agent as well.

from pr-agent.

zmeir avatar zmeir commented on July 22, 2024

This was primarily added to deal with Azure / Replicate related issues where the model calls would hang for an unusual amount of time.

It's possible that this is the issue I'm facing since I'm using Azure. I've only ever noticed it happen with /improve though, never with /review, /describe, etc.

from pr-agent.

krrishdholakia avatar krrishdholakia commented on July 22, 2024

I'm guessing pre-lite it didn't timeout, so did it hang or always complete successfully?

from pr-agent.

zmeir avatar zmeir commented on July 22, 2024

From what I can tell it always completed successfully, but then again this is all pretty new stuff so it's possible I just didn't run into a large enough PR when using /improve in the pre-lite agent.

When I get the timeout again I'll try to run the pre-lite agent on the same PR and see if it works.

from pr-agent.

krrishdholakia avatar krrishdholakia commented on July 22, 2024

sounds great! i'll put set_timeouts as an optional param, which should remove any lite-related blockers between you-your azure calls.

from pr-agent.

krrishdholakia avatar krrishdholakia commented on July 22, 2024

update: default timeouts are now set to 600 seconds (~10 minutes)

from pr-agent.

zmeir avatar zmeir commented on July 22, 2024

update: tested /improve again today on a fairly large PR with the latest main version and it didn't time out. I'll close this issue for new, and if it resurfaces I'll reopen it / open a new one with more details.

from pr-agent.

mrT23 avatar mrT23 commented on July 22, 2024

/similar_issue

from pr-agent.

github-actions avatar github-actions commented on July 22, 2024

Similar Issues:

  1. [GITLAB] Installation Guide for GitLab please?

  2. Failure in /improve command

  3. Running Github Action: openai.error.RateLimitError

from pr-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.