Giter Site home page Giter Site logo

Comments (4)

colinrtwhite avatar colinrtwhite commented on July 25, 2024

Interesting! imageView.load(String) is currently reserved for HTTP URLs, but we should at least support imageView.load(Uri.parse("file:///android_asset/starrynight.jpg")). I think we could make the necessary changes in UriFetcher. I'll make a quick PR.

from coil.

ianhanniballake avatar ianhanniballake commented on July 25, 2024

load(Uri) support would be great, thanks!

It seems like in other image loading libraries, load(uri: String) = load(Uri.parse(uri)) in all cases and they share the same underlying processing. This ensures that no matter if developers use a String or Uri, the same rules apply, avoiding all cases where developers need to remember to htmlUri.toString() or Uri.parse(contentUriString). Probably worth a separate FR than this as that would be a wider issue than this particular case.

from coil.

colinrtwhite avatar colinrtwhite commented on July 25, 2024

Good point. Currently, Coil uses url as the named param for load(String) so we'd have to change that to something more general (but hopefully not too general like data; let me know if you have suggestions), but I like the idea of supporting Uris and Urls via load(String).

We could support this by writing a new Mapper or modifying HttpUrlMapper.

from coil.

colinrtwhite avatar colinrtwhite commented on July 25, 2024

Created a new issue to support parsing Strings as Uris here: #24

from coil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.