Giter Site home page Giter Site logo

New R package for REST API about coinapi-sdk HOT 7 CLOSED

coinapi avatar coinapi commented on April 29, 2024
New R package for REST API

from coinapi-sdk.

Comments (7)

Svisstack avatar Svisstack commented on April 29, 2024

@Ramshreyas Great job!

Can you just make PR to this repo as we will have it in ./data-api/r-rest-2 directory and other people can participate in developing that alongside?

from coinapi-sdk.

Ramshreyas avatar Ramshreyas commented on April 29, 2024

@Svisstack sure, I'll do that but to be honest it won't be very useful to R coders.

The way R works developers working with github packages (as opposed to the official CRAN repos) do this:

install_github("Ramshreyas/rcoinapi")

With just the "name of the user/name of repo" as the argument.

You will be better off forking my repo, so that they can do:

install_github("coinapi/r")

or whatever name you prefer. Then PRs can go directly to that repo and usage, testing etc will work out of the box.

Plus, the way the auto-generated documentation (which I've also created) namespace etc works, it's better if it is at the root of the repo and therefore easy for others to work with.

If the code is buried in your SDKs repo, there are a couple of steps before R programmers can get started working with the package immediately, and they will have to do it each time they want to make a change.

Let me know how you would like to proceed!

Also, I'm putting together a tutorial which shows the API working within a typical R backtesting workflow, which I'll post here once it's ready.

from coinapi-sdk.

Ramshreyas avatar Ramshreyas commented on April 29, 2024

@Svisstack : as promised, here is a complete tutorial using RCoinAPI (or whatever you want to call it in the future) to get Crypto data and perform a backtest using Quantstrat, the industry standard for backtesting in R:

https://philosophyofquant.com/post/2021-07-05-rcoinapi/

Please let me know if you prefer a PR to your existing repo (which I'd advise against) or would you like to just fork my repo, and we can proceed and close accordingly.

Cheers!

from coinapi-sdk.

Ramshreyas avatar Ramshreyas commented on April 29, 2024

@Svisstack I'm assuming you prefer the code under ./data-api/r-rest-2 as opposed to a new repo - have made the PR accordingly.

from coinapi-sdk.

Svisstack avatar Svisstack commented on April 29, 2024

Hi, @Ramshreyas Thanks for making that happen in the subdirectory fashion as it reflects our current SDK structure where there multiple languages in the separate subdirectories instead of separate repositories.

Can you also advise if that import line is correct after the merge?

0b8aa47#diff-727b26c4933a46e039d64e662a92c107252bbd9b4579dfc2fe97f6824af8cf19R28

Thanks for the contribution!

from coinapi-sdk.

Ramshreyas avatar Ramshreyas commented on April 29, 2024

from coinapi-sdk.

Svisstack avatar Svisstack commented on April 29, 2024

@Ramshreyas Thanks for confirming. Have a nice week.

from coinapi-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.