c# Websocket SDK - Use ConcurrentQueue instead of Queue and Remove Lock for faster receiving of Data

[penguinawesome]

c# Websocket SDK - Use ConcurrentQueue instead of Queue and Remove Lock for faster receiving of Data

[Svisstack]

This is more complicated as the ConcurrentQueue has a memory leak that will not be fixed, so we avoid it as much as possible, but there are other viable resolutions to this problem, however, this should be properly benchmarked.

[penguinawesome]

@Svisstack i saw that issue, however i'm not sure if it is still happening on newer .net framework (like .net framework > 4.7.2 or 4.8 or .net 5).

There is still article: https://devblogs.microsoft.com/pfxteam/concurrentqueuet-holding-on-to-a-few-dequeued-elements/

We are using concurrent queue on other parts of our code, so far we didn't experience any memory leak problem

[Svisstack]

The leak still exists in .NET 5.0. Its presence is highly dependent on how you actually use the collection and on the number of elements, but it's a too big problem to let roll the dice.

[penguinawesome]

Alright Thanks @Svisstack for your insights.