ESLint, Typings Declaration File?

[coinbase]

ESLint, Typings Declaration File?

[JakeRad]

@ColtonProvias @kiwileaks78 @condulum I've started a fork with a typings ... feel free to help out!

Pull Request:
#108

Fork:
https://github.com/JakeRad/gdax-node

npm install command:
npm install github:JakeRad/gdax-node

@fb55 Thoughts on merging this in?

[fb55]

We're currently reworking how this library works, let's wait for that to happen before adding typings. Thanks a lot for the offer though, I'll definitely come back to it!

Part of that change will be to use prettier for formatting the code, which will already take care of a lot of the advantages of airbnb's config. I'd prefer to maintain the remaining settings in this repo (it won't be that many anyway).

[kiwileaks78]

Having typings would be awesome !

[awitherow]

There is already a pretty large conversion of the codebase to a newer flavor of es6... adding type support would either need to be done by https://flow.org or typescript.

Flow would be the easiest to begin implementing, while typescript would require another rewrite... not sure if that would be desirable.

When minimally implemented (as needed, in effective areas), flowtype can be really beautiful. Otherwise it can turn your codebase into a monster you never want to touch again.

[ColtonProvias]

I'm actually finding myself in the position of rewriting this to TypeScript right now. When I'm done or close to it, I'll throw it up on GitHub.

[fb55]

Merged it! :D — Thanks a lot @JakeRad!