Giter Site home page Giter Site logo

Cant edit landing page about lotusdocs HOT 14 OPEN

colinwilson avatar colinwilson commented on July 28, 2024 3
Cant edit landing page

from lotusdocs.

Comments (14)

colinwilson avatar colinwilson commented on July 28, 2024 2

I added theme as a module. So I can't delete theme data file. It seems like it combines theme data and my project data.

Ah ha. Yes this is a problem. I'll look at resolving this very soon (next update).

from lotusdocs.

colinwilson avatar colinwilson commented on July 28, 2024

Have you tried deleting the theme's landing.yaml file?

from lotusdocs.

rusinikita avatar rusinikita commented on July 28, 2024

I added theme as a module. So I can't delete theme data file. It seems like it combines theme data and my project data.

Hero and "what can i do" sections is mine, but other is sample. It happened when I had updated theme to last commit version.

Workaround: Disabling keys from sample helps.

featureGrid:
  enable: false
imageCompare:
  enable: false
Screenshot 2023-12-18 at 20 28 13

from lotusdocs.

rusinikita avatar rusinikita commented on July 28, 2024

Only one problem. ctaButton button always leads to root. No matter ctaButton.url setting. So I was forced to use cta2Button

https://github.com/rusinikita/changes/pull/6/files

from lotusdocs.

indrora avatar indrora commented on July 28, 2024

The workaround doesn't work, by the way. It crashes out saying that a partial failed:

image

This sucks.

Followup: https://gohugo.io/templates/data-templates/ -- There's a note about this specifically:

Therefore, theme authors should be careful not to include data files that could be easily overwritten by a user who decides to customize a theme. For theme-specific data items that shouldn’t be overridden, it can be wise to prefix the folder structure with a namespace.

from lotusdocs.

rusinikita avatar rusinikita commented on July 28, 2024

I guess, there is something inside your configuration. Can you provide file.

from lotusdocs.

indrora avatar indrora commented on July 28, 2024

Here's the most minimal repro:

hero:
  enable: false

featureGrid:
  enable: false

The full error I get:

ERROR Rebuild failed: render: failed to render pages: render of "home" failed: "/Users/indrora/Library/Caches/hugo_cache/modules/filecache/modules/pkg/mod/github.com/colinwilson/[email protected]/layouts/index.html:19:11": execute of template failed at <partialCached $path ($indexContext.Get "indexContext")>: error calling partialCached: partial "landing/featureGrid.html" not found

This tells me that it's making a guess as to what template, but moreover not checking if the section has enable set to true.

But wait, the plot thickens!

The following raises a New and Interesting error:

hero: 
  enable: false

mycoolsection:
  enable: false
  template: asdf

this causes a NEW bug to show up:

ERROR Rebuild failed: render: failed to render pages: render of "home" failed: "/Users/indrora/Library/Caches/hugo_cache/modules/filecache/modules/pkg/mod/github.com/colinwilson/[email protected]/layouts/index.html:19:11": execute of template failed at <partialCached $path ($indexContext.Get "indexContext")>: error calling partialCached: partial "landing/mycoolsection.html" not found

There's actually multiple bugs here:

  • The template provides data that is being used, and instead should supply at most some filler data that gets set aside if there is a site-specific dataset
  • The template does not check to see if the enable field is set
  • The template is derived from the key rather than from the template field

Edit: it appears I was on an older version. Once I forced Hugo to use the release branch, it worked.

from lotusdocs.

aMytho avatar aMytho commented on July 28, 2024

What version or git commit did you use to get the workaround functional? I'm on version v0.121.1-00b46fed8e47f7bb0a85d7cfc2d9f1356379b740+extended and I get the same error you showed when I disable the feature grid and image compare sections.

from lotusdocs.

rusinikita avatar rusinikita commented on July 28, 2024

@aMytho Here is my version that works

https://github.com/rusinikita/changes/blob/main/docs/go.mod
https://rusinikita.github.io/changes/

from lotusdocs.

aMytho avatar aMytho commented on July 28, 2024

That worked for me, thank you!

@aMytho Here is my version that works

https://github.com/rusinikita/changes/blob/main/docs/go.mod https://rusinikita.github.io/changes/

from lotusdocs.

chapimenge3 avatar chapimenge3 commented on July 28, 2024

I think this problem happens only when you use lotus docs as a submodule? I faced the same problem today my configuration is like the below

hero:
    ....
    badge:
    text: custom text
    color: primary # primary, secondary, success, danger, warning, info, light, dark
    pill: false # boolean
    soft: true # boolean

featureGrid:
  enable: true
  weight: 20
  template: feature grid

  title: This is updated.
  subtitle: Lotus Docs is a highly configurable Hugo documentation theme. 

Hero page was working fine it override it, but feature grid just won't work.

but what I used this repo as a template, and everything started working.

from lotusdocs.

ManuelLevi avatar ManuelLevi commented on July 28, 2024

I'm facing the same issue.

I've installed this as a Hugo Module following the instructions here.

When I add my data/landing.yaml I can edit Hero and it works, everything else doesn't.

I've tried the workaround but also didn't work. I can provide more information on my context, if you tell me what you need :)

from lotusdocs.

chapimenge3 avatar chapimenge3 commented on July 28, 2024

Use the template from the repo of the docs itself @ManuelLevi

from lotusdocs.

ManuelLevi avatar ManuelLevi commented on July 28, 2024

Thanks @chapimenge3

I've copied the contents of these files (one at a time):

  • /data/landing.yaml
  • /exampleSite/data/landing.yaml

to my /data/landing.yaml.

Neither of them worked. I can change the Hero, but nothing else.

from lotusdocs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.