Comments (14)
👍 It'd be great to get this dependency loosened to allow for 4.0.
from delayed_job_active_record.
Has anyone tested this?
from delayed_job_active_record.
Looks like collectiveidea/delayed_job#464 would also need to be merged in. When running the suite locally with Ruby 2.0.0-p0, ActiveRecord 4.0.0.beta1, ActiveSupport 4.0.0.beta1, it does fail now that attr_accessible
has been extracted into a separate gem, along with a bunch of warnings.
DEPRECATION WARNING: ActiveSupport::BasicObject is deprecated! Use ActiveSupport::ProxyObject instead. (called from <module:Delayed> at /Users/alex/Rails/gems/delayed_job/lib/delayed/message_sending.rb:5)
DEPRECATION WARNING: Calling #default_scope without a block is deprecated. For example instead of `default_scope where(color: 'red')`, please use `default_scope { where(color: 'red') }`. (Alternatively you can just redefine self.default_scope.). (called from <class:Story> at /Users/alex/Rails/gems/delayed_job_active_record/spec/spec_helper.rb:47)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:48)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:49)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:50)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:51)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:52)
DEPRECATION WARNING: Relation#update_all with conditions is deprecated. Please use Item.where(color: 'red').update_all(...) rather than Item.update_all(..., color: 'red'). (called from clear_locks! at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:40)
An error occurred in an after hook
RuntimeError: `attr_accessible` is extracted out of Rails into a gem. Please use new recommended protection model for params(strong_parameters) or add `protected_attributes` to your Gemfile to use old one.
occurred at /Users/alex/.rvm/gems/ruby-2.0.0-p0@delayed_job_active_record/gems/activemodel-4.0.0.beta1/lib/active_model/deprecated_mass_assignment_security.rb:14:in `attr_accessible'
Sorry for jumping to the conclusion that this was ready for a simple version dependency change!
from delayed_job_active_record.
+1 for making it compatible with rails 4.0.0.beta1
from delayed_job_active_record.
Gem version 4.0.0.beta2
should provide support for Rails 4.
from delayed_job_active_record.
Trying to install 4.0.0.beta3 and get this error:
delayed_job_active_record (= 4.0.0.beta3) ruby depends on
activesupport (~> 3.0) ruby
Current version of activesupport is of course 4.0.0.
However, the beta2 seems to work fine in Rails 4.
from delayed_job_active_record.
You have to use the beta version of delayed_job_active_record
from delayed_job_active_record.
I thought I was clear it is the latest beta (beta3) that doesn't work with Rails 4, but the previous does (beta2).
from delayed_job_active_record.
Something in your gemfile or lock file is doing that, not delayed_job_active_record. Do you have your gemfile requiring the beta of DJ as well?
from delayed_job_active_record.
I had this line in my Gemfile:
gem 'delayed_job_active_record', '4.0.0.beta3'
And that's when I got the error above, this time I'm adding the full error:
Bundler could not find compatible versions for gem "activesupport":
In Gemfile:
delayed_job_active_record (= 4.0.0.beta3) ruby depends on
activesupport (~> 3.0) ruby
clockwork (>= 0) ruby depends on
activesupport (4.0.0)
But when I switched the line to:
gem 'delayed_job_active_record', '4.0.0.beta2'
It worked.
Any clue what's happening?
from delayed_job_active_record.
Do you have
gem "delayed_job", "~> 4.0.0.beta2"
in your gemfile?
from delayed_job_active_record.
Nope, just the delayed_job_active_record gem.
from delayed_job_active_record.
You need both
from delayed_job_active_record.
Alright, that did the trick. Thanks!
from delayed_job_active_record.
Related Issues (20)
- Rails 6.1.0.alpha support HOT 3
- `Delayed::Job` no longer defined in initializers HOT 16
- Delayed::DeserializationError: Job failed to load: undefined class/module Spree::AccountSalesRecordMailer.
- undefined method `table_name=` for Delayed::Backend::ActiveRecord::Job:Class HOT 1
- 4.1.5 breaking changes HOT 5
- A way to get the job ID inside a worker? HOT 2
- Error in 4.1.5 when upgrading Rails from 6.0 to 6.1 HOT 2
- Job running on 2 workers at once after timeout HOT 1
- Delayed job stops, the jobs are stuck in postgres HOT 6
- Rails 7 Support HOT 9
- Use case for locked_by in the ready_to_run query HOT 1
- Use `update` instead of `update_all` in the reserve_with_scope_using_optimized_mysql method. HOT 1
- Do that destroy_failed_jobs get honored by delayed_job? HOT 1
- Problem with DelayedJob Psych gem when upgrading to Ruby 2.7.5 HOT 2
- Rails 7 weird error: can't dump anonymous module HOT 3
- Can't create Delayed::Job record after `errors.add` in model HOT 1
- How does max_attempts interface with ActiveJob retry_on method? HOT 1
- Deprecation warning in rails 7.1 HOT 1
- Need a new release to support rails 7.1
- Don't optimize mysql query with trilogy gem
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delayed_job_active_record.