Locking no longer functions correctly

[collectiveidea]

Locking no longer functions correctly

[jeyb]

Running into the same problem with MySQL.

In addition, we are seeing Delayed::Job record not found exceptions as one job finished processing the job while the other is attempting to lock. This literally crashes the worker process.

[pa657]

Same issue.

[jensblond]

+1

[sirkosi]

+1

[n8gard]

Ah. That explains a lot.

+1

Same issue and my app is presently very lightly loaded: 2 workers and 4-5 jobs/sec.

On Mar 6, 2013, at 12:58 PM, Aguilar [email protected] wrote:

Same issue.

—
Reply to this email directly or view it on GitHub.

[martoche]

+1

[n8gard]

I've already +1'd this but have a question.

We are building an application at my company and are delivering and demoing a prototype next week to management. Is this going to be fixed? If not, can anyone suggest what alternative solution I should rapidly swap out to? I have been having workers crash in testing and believe it to be this issue.

I need to demonstrate background data processing early next week and can't have workers crashing. Until I noticed this thread, I've been blaming it on my EC2 instances and pulling my hair out. :)

Thanks all.

N
On Mar 11, 2013, at 4:47 AM, Martin Ottenwaelter [email protected] wrote:

+1

—
Reply to this email directly or view it on GitHub.

[maletor]

Lock the dependency at 0.4.1.

On Monday, March 11, 2013, njnorrgard wrote:

I've already +1'd this but have a question.

We are building an application at my company and are delivering and
demoing a prototype next week to management. Is this going to be fixed? If
not, can anyone suggest what alternative solution I should rapidly swap out
to? I have been having workers crash in testing and believe it to be this
issue.

I need to demonstrate background data processing early next week and can't
have workers crashing. Until I noticed this thread, I've been blaming it on
my EC2 instances and pulling my hair out. :)

Thanks all.

N
On Mar 11, 2013, at 4:47 AM, Martin Ottenwaelter <[email protected]<javascript:_e({}, 'cvml', '[email protected]');>>
wrote:

+1

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-14721097
.

[KieranP]

Bump. This is a fairly important issue that needs to be fixed ASAP because it can lead to all sorts of havoc, such as email users multiple times for the same thing (think credit card payment notifications being sent out 3-5 times!).

[fionaom]

+1

[kwent]

+1 !

[snusmu]

+1474

thats the amount of dj's created overnight after we updated dj_ar to 0.4.2

+1

So the fix is to lock the version to 0.4.1 in the Gemfile?
If I do "gem list" I don't even see delayed_job_active_record, so not sure how I can uninstall the 0.4.3 version.

[brupm]

+1

+1

[Cr1stal]

+1

[donbobka]

+1

[pashpashkin]

+1

[andrey-lizunov]

+1

[mmoldavan]

+1

[gaffneyc]

Would someone be willing to put together a pull request to fix this?

[martoche]

See my conversation on Twitter with @sferik: https://twitter.com/martoche/status/317284063134228480

[gaffneyc]

@martoche Understandable that you don't feel comfortable enough with the codebase to make a pull request. And it really sucks that this has been outstanding as long as it has been.

That said... if anyone following this ticket is willing to do the work to revert those commits and make a pull request we can likely get a new gem cut today and the old one yanked. At the very least we'll get the bad gem yanked today.

[gaffneyc]

And can anyone confirm that this was introduced in 0.4.2?

[sferik]

I'm sorry it has taken so long for me to get to this issue. I’ve merged @albus522’s patch into master and cherry-picked the relevant changes into the 0-4-stable branch.

Can someone please confirm the fix by replacing the delayed_job_active_record line in their Gemfile with:

gem 'delayed_job_active_record', :git => 'git://github.com/collectiveidea/delayed_job_active_record.git', :branch => '0-4-stable' # or 'master' for Rails 4

After this fix is confirmed, I will release gem versions 0.4.4 and 4.0.0.beta2. Unless the patch introduces new issues, these gems should be released later today.

[martoche]

There's no way to test this? I don't feel confortable with pushing this in production to test it.

[sferik]

I've released gem versions 0.4.4 and 4.0.0.beta2.

[justincampbell]

This is fixed for me in 4.0.0.beta2

Thanks!

[jamsi]

Adding this to my Gemfile + bundle install fixed the issue for me.

gem 'delayed_job_active_record', '0.4.1'

[sferik]

@jamsi Can you please try version 0.4.4 (released this morning) and let me know if that works for you?

[kwent]

Seems OK with 0.4.4 for me. Thanks !

[jamsi]

@sferik 0.4.4 seems to be ok too. I'm just glad I caught this before I pushed to production. It's a hard thing for rspec to pickup =\

Many thanks.