PYCOLMAP failed building on Windows

[colmap]

PYCOLMAP failed building on Windows

[stevosaurus]

I was getting the same error today and figured out a way to resolve it. Unfortunately, I don't know enough about cmake/vcpkg/pycolmap to know why the files in the /exe dir aren't being included during the build, but I was able to get the build working by manually copying the include/colmap/exe directory from the colmap repository into my vcpkg colmap include directory.

Essentially, the exe header files are not in this directory and need to be for the build to work:
{vcpkg_dir}\installed\x64-windows\include\colmap

[sarlinpe]

colmap/exe/feature.h was only exposed recently in the installed library: colmap/colmap@83aa340 I don't use Windows so I don't know how vcpkg works, I guess that it should have pulled the latest COLMAP commit.

[bycloudai]

@stevosaurus do you mind elaborating a bit more? I've tried getting the files feature.h included from colmap/src/head/dev-55e04ac3eb.clean/src/exe to vcpkg/installed/x64-windows/include/colmap but it still the same error unfortunately.

[yocabon]

this line here is the problem I believe https://github.com/microsoft/vcpkg/blob/47cbed88514c0e48fdb72ddc29545f35136f5461/ports/colmap/portfile.cmake#L69
this folder was empty before and thus removed at the end of the build but it's no longer the case.
I removed it on my machine, compiled colmap; then installed pycolmap and it seem to work.

[mexicantexan]

Unrelated

CMake Deprecation Warning at scripts/cmake/vcpkg_check_features.cmake:182 (message):
  calling `vcpkg_check_features` without the `FEATURES` keyword has been
  deprecated.

      Please add the `FEATURES` keyword to the call.
Call Stack (most recent call first):
  ports/libjpeg-turbo/portfile.cmake:35 (vcpkg_check_features)
  scripts/ports.cmake:142 (include)

[sarlinpe]

We now have instructions to build PyCOLMAP on Windows. We also have pre-built wheels that are available here and can be installed with pip. I don't have a Windows machine at hand so it'd be great if someone could confirm that they work. We'll then release them on PyPI.