Giter Site home page Giter Site logo

Comments (2)

rob-p avatar rob-p commented on June 14, 2024

Hi @ATpoint,

You're right that the exit code isn't set properly in this case. At some point, we switched from the "historic" unit return type for main (where all non-zero exit codes had to result from a std::process::exit) to the more modern Result<()> return type for main. Some code paths (like this one, I believe) slipped through the cracks. It seems it wants to print the error message, but that doesn't prevent it from returning 0 (i.e. returning Ok(()) from main). I think the right thing to do here is to ensure in this path that we return Err(<appropriate error message here>), which will both show the message and force the exit code to 1.

Thanks!
Rob

from alevin-fry.

rob-p avatar rob-p commented on June 14, 2024

Fixed in 0.8.1.

from alevin-fry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.