Giter Site home page Giter Site logo

Comments (2)

hartym avatar hartym commented on May 24, 2024

Also, I'm wondering if the choice of using component based react devtools instead of chrome extension devtools is a choice, or just a coincidence ?

from universal-react-redux.

calvinl avatar calvinl commented on May 24, 2024
  1. The reason is primarily because of Redux Devtools, which recommends the split. It is a bit more maintenance, and originally I had a single file using conditionals, but I thought about other users who might want to include additional tooling in development, and this makes it easier and clearer to ensure you're adding it to the right place.

That said, I don't mind removing the component based redux devtools in favor of adding something to the README that recommends using the chrome extension instead. I didn't know the chrome extension existed at the time I published this starter kit.

  1. re: server environment variables. I don't really mind doing this, but I can see one downside, and that's confusion to the user thinking that the variables are being defined by Webpack, when they're not. The server only uses the isomorphic webpack configuration for assets.

I say go ahead and submit a patch for the server variables, but I'd recommend leaving the separate dev/prod stores.

from universal-react-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.